Custom versioning for cypress/browsers

[BreakBB]

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us what version of Renovate you run.

37.50.2@sha256:78dcbe976097ab0425bd7387670d7ef1316be0e748a8aa33bed4964b923d3552

If you're self-hosting Renovate, select which platform you are using.

GitLab self-hosted

Was this something which used to work for you, and then stopped?

I never saw this working

Wanted end result.

I am looking for help to configure renovate to support cypress/browsers. The docker images are named quite interesting and as already answered in #18057 I need a custom versioning regex to get this to work.

What you tried so far.

This is the config I provided in the packageRules:

        {
            "matchDatasources": [
                "docker"
            ],
            "matchManagers": [
                "dockerfile"
            ],
            "matchPackageNames": [
                "cypress/browsers"
            ],
            "versioning": "regex:^node-?(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<patch>\\d+)(?:-(?:[a-zA-Z]+\\d*|[\\d.]+))*$"
        }

That regex matches all of these:

1. node16.18.0-chrome107-ff106-edge
2. node16.16.0-chrome107-ff107-edge
3. node-16.18.1-chrome-107.0.5304.121-1-ff-107.0-edge-100.0.1185.29-1
4. node-20.9.0-chrome-118.0.5993.88-1-ff-118.0.2-edge-118.0.2088.46-1

The first version above is the one currently used in my project.

Full renovate.json

renovate.json

{
    "$schema": "https://docs.renovatebot.com/renovate-schema.json",
    "extends": [
        "config:base"
    ],
    "labels": [
        "renovate"
    ],
    "prHourlyLimit": 0,
    "prConcurrentLimit": 0,
    "separateMultipleMajor": true,
    "rangeStrategy": "pin",
    "branchPrefix": "REN-",
    "ignoreDeps": [
        "tomcat"
    ],
    "enabledManagers": [
        "docker-compose",
        "dockerfile",
        "maven",
        "gitlabci",
        "npm",
        "nvm"
    ],
    "packageRules": [
        {
            "matchUpdateTypes": [
                "pin"
            ],
            "addLabels": [
                "pin"
            ],
            "automerge": true,
            "platformAutomerge": true
        },
        {
            "matchUpdateTypes": [
                "patch"
            ],
            "addLabels": [
                "patch"
            ],
            "automerge": true,
            "platformAutomerge": true
        },
        {
            "matchUpdateTypes": [
                "minor"
            ],
            "addLabels": [
                "minor"
            ]
        },
        {
            "matchUpdateTypes": [
                "major"
            ],
            "addLabels": [
                "major"
            ]
        },
        {
            "enabledManagers": [
                "npm"
            ],
            "matchDepTypes": [
                "devDependencies"
            ],
            "addLabels": [
                "devDependency"
            ]
        },
        {
            "matchUpdateTypes": [
                "digest",
                "minor",
                "patch"
            ],
            "matchManagers": [
                "gitlabci"
            ],
            "matchPackagePatterns": [
                "renovate\\/renovate*"
            ],
            "automerge": true,
            "automergeType": "pr",
            "platformAutomerge": true
        },
        {
            "matchManagers": [
                "gitlabci"
            ],
            "matchPackageNames": [
                "node"
            ],
            "versioning": "node"
        },
        {
            "extends": "monorepo:electron-forge",
            "groupName": "electron-forge monorepo",
            "matchUpdateTypes": [
                "digest",
                "patch",
                "minor",
                "major"
            ]
        },
        {
            "matchDatasources": [
                "docker"
            ],
            "matchManagers": [
                "dockerfile"
            ],
            "matchPackageNames": [
                "cypress/browsers"
            ],
            "versioning": "regex:^node-?(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<patch>\\d+)"
        }
    ]
}

Relevant debug logs

Logs

DEBUG: Dependency cypress/browsers has unsupported/unversioned value node16.18.0-chrome107-ff106-edge (versioning=docker)
...
               {
                 "depName": "cypress/browsers",
                 "currentValue": "node16.18.0-chrome107-ff106-edge",
                 "replaceString": "cypress/browsers:node16.18.0-chrome107-ff106-edge",
                 "autoReplaceStringTemplate": "{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}",
                 "datasource": "docker",
                 "depType": "image-name",
                 "updates": [],
                 "packageName": "cypress/browsers",
                 "versioning": "docker",
                 "warnings": [],
                 "skipReason": "invalid-value"
               },

[rarkins]

Please describe in simple terms what logic should be used to determine if an update is valid or not

[BreakBB]

Sufficient enough would be to use the latest node version. So use the semVer after "node".

[rarkins]

And somewhere during node 16 they changed from node16 syntax to node-16?

[BreakBB]

There are even "node18-x" images and also "node-18-x" ... 🤦🏻

[rarkins]

In that case I would have gone for a simpler regex match which ignores the last part:

        {
            "matchDatasources": [
                "docker"
            ],
            "matchManagers": [
                "dockerfile"
            ],
            "matchPackageNames": [
                "cypress/browsers"
            ],
            "versioning": "regex:^node-?(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<patch>\\d+)"
        }

[BreakBB]

Thanks rarkins, these are my first steps using a custom versioning, so your help is appreciated! Unfortunately the logs are unchanged from that regex.

I edited my initial post and added my full renovate.json content. Maybe it's not the regex that is wrong? 🤔

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the discussion if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

[BreakBB]

I created a fresh repo and can reproduce the issue: https://github.com/BreakBB/renovate-cypress-browsers

The interesting part is the version in the Dockerfile gets a PR while the .gitlab-ci.yml does not. The logs again say:

DEBUG: Dependency cypress/browsers has unsupported/unversioned value node16.18.0-chrome107-ff106-edge (versioning=docker)

A side question: Can I manually set the renovate version of the Github app? The logs say it is running with "renovateVersion": "37.46.0" 🤔

[rarkins]

You can manually configure the versioning for a dependency and you need to do so for the gitlab-ci. You cannot configure the version of Renovate

[BreakBB]

I feel so stupid right now, for overseeing that I configured the custom versioning for the wrong manager 🤦🏻

Thank you very much (again) for your great help rarkins!