Implement support of "<codename>-<date>" version format for Debian docker images #27806
Replies: 5 comments 17 replies
-
|
This might be possible to work already using versionCompatibility. Can you create a reproduction repo? |
Beta Was this translation helpful? Give feedback.
-
|
Absolutely, here's the repo: https://github.com/fclaerho/repro_renovatebot_27806 I checked the doc for versionCompatibility, but I'm not sure to understand how to use it… |
Beta Was this translation helpful? Give feedback.
-
|
Ubuntu versioning has this function specifically for that type of tagging: renovate/lib/modules/versioning/ubuntu/common.ts Lines 3 to 5 in d111a1e Debian versioning doesn't have the same. You can achieve the same result though with this config: https://github.com/renovate-reproductions/27806/blob/d829173c3fda829c220c7ce3f7a8185c7b81cc86/renovate.json#L13-L14 |
Beta Was this translation helpful? Give feedback.
-
|
First, thank you for the quick replies! So, I tried out the workaround, there is good news and bad news -- applying the versionCompatibility directive does allow to extract the version, and Renovate does find that there is an update available: But, semantically, it considers it's a "major" (updateType) whereas it should be a minor or a patch, as it's done on the Ubuntu side: So, this won't work in my case as I don't want major updates (the context being regression testing on specific platforms.) Now -- re-reading the Renovate doc on Docker, the recommended practice is to actually use digests: |
Beta Was this translation helpful? Give feedback.
-
|
Directly using renovate.json {
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["regexManagers:dockerfileVersions"],
"packageRules": [
{
"matchDatasources": ["docker"],
"matchPackageNames": ["debian"],
"versioning": "regex:^(?<compatibility>.*)-(?<minor>\\d+)$"
}
]
}Dockerfile Result |
Beta Was this translation helpful? Give feedback.
-
|
Hi there, Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible. Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. To get started, please read our guide on creating a minimal reproduction. We may close the discussion if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment. Good luck, The Renovate team |
Beta Was this translation helpful? Give feedback.
-
|
Converted to issue: #27862 |
Beta Was this translation helpful? Give feedback.
-
|
I'm trying to extend the solution provided to match those debian tags: |
Beta Was this translation helpful? Give feedback.
-
|
In other words the only two valid capture groups for versionCompatibility are version and compatibility. Everything else is essentially ignored, and won't be included in version or compatibility comparisons. |
Beta Was this translation helpful? Give feedback.
-
Does the same behavior apply to the version I posted?
Is the My automated production build now relies on this, so if it can cause damage I would need to revert it. Thanks for your time! EDIT: At least from the logs it looks like it's working as expected. {
"depName": "debian",
"packageName": "debian",
"currentValue": "bookworm-20240408-slim",
"datasource": "docker",
"replaceString": "# renovate: datasource=docker depName=debian packageName=debian\nARG DEBIAN_VERSION=bookworm-20240408-slim\n",
"updates": [
{
"bucket": "non-major",
"newVersion": "bookworm-20240423-slim",
"newValue": "bookworm-20240423-slim",
"newMajor": 0,
"newMinor": 20240423,
"updateType": "minor",
"newDigest": "sha256:155280b00ee0[1332](https://github.com/talent-ideal/renovate/actions/runs/8985446512/job/24679453385#step:4:1333)50f7159b567a07d7cd03b1645714c3a7458b2287b0ca83cb",
"branchName": "ti-renovate/debian-0.x"
}
],
"versioning": "regex:^(?<compatibility>.*)-(?<minor>\\d+)-slim$",
"warnings": [],
"registryUrl": "https://index.docker.io/",
"lookupName": "library/debian",
"currentVersion": "bookworm-20240408-slim",
"isSingleVersion": true,
"fixedVersion": "bookworm-20240408-slim"
}
|
Beta Was this translation helpful? Give feedback.
-
|
regex versioning is different to versionCompatibility (they solve similar problems though). In a case like the above, your regex versioning enforces that the |
Beta Was this translation helpful? Give feedback.
-
|
It is! (see my full comment with PR screenshot) The only issue I notice is the branch name being set to |
Beta Was this translation helpful? Give feedback.
-
|
I do the it with |
Beta Was this translation helpful? Give feedback.
-
|
Hi there, This is intended as a polite, automated request that users avoid We know it might be common elsewhere but we participate in hundreds of discussions a week and would need to turn off GitHub mobile notifications if we were mentioned in every one. As a general rule, we will read and respond to all discussions in this repository, so there is no need to mention us. Thanks, the Renovate team |
Beta Was this translation helpful? Give feedback.
-
Tell us more.
As stated by the documentation at:
https://docs.renovatebot.com/modules/versioning/#debian-versioning
The current
debianversioning scheme does not support the<codename>-<date>version format.However it's already supported by the
ubuntuversioning scheme:https://docs.renovatebot.com/modules/versioning/#ubuntu-versioning
It would be nice to port that feature from ubuntu to debian.
Beta Was this translation helpful? Give feedback.
All reactions