Support source and changelog links for sbt manager in the same way as for maven manager

[gaeljw]

Tell us more.

I just noticed a small difference of behaviour between sbt and maven managers when it comes to extracting source code and changelog.

Example for Maven:

Description	Diff

Example for sbt:

Description	Diff

Notice the "source" and "changelog" links are not present for sbt.

As sbt and maven share the same datasource (in this case at least, = maven registry), I guess sbt manager could extract the info in the same way as the maven manager does, right?

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

To get started, please read our guide on creating a minimal reproduction.

Good luck,

The Renovate team

[gaeljw]

Here it is: https://github.com/gaeljw/renovate_28422

[rarkins]

If it's the same datasource then it should behave the same. But some packages don't have source URLs provided. Needs a reproduction

[gaeljw]

I noticed the Maven case seem to be identified as "monorepo" while the sbt doesn't. Not sure if it makes a difference.

Monorepo presets:

• https://docs.renovatebot.com/presets-monorepo/#monoreposlf4j
• https://docs.renovatebot.com/presets-group/#groupslf4jmonorepo

Anyway, here's a reproduction repo:

• Maven PR: Update dependency org.slf4j:slf4j-api to v2.0.13 gaeljw/renovate_28422#4
• sbt PR: Update dependency org.slf4j:slf4j-api to v2.0.13 gaeljw/renovate_28422#2

[rarkins]

Here's the log for your reproduction:

DEBUG: packageFiles with updates (repository=gaeljw/renovate_28422, baseBranch=main)
       "config": {
         "maven": [
           {
             "datasource": "maven",
             "packageFile": "pom.xml",
             "deps": [
               {
                 "datasource": "maven",
                 "depName": "org.slf4j:slf4j-api",
                 "currentValue": "2.0.12",
                 "fileReplacePosition": 83,
                 "registryUrls": ["https://repo.maven.apache.org/maven2"],
                 "depType": "compile",
                 "groupName": "slf4j.version",
                 "updates": [
                   {
                     "bucket": "non-major",
                     "newVersion": "2.0.13",
                     "newValue": "2.0.13",
                     "releaseTimestamp": "2024-04-12T14:24:04.000Z",
                     "newMajor": 2,
                     "newMinor": 0,
                     "updateType": "patch",
                     "branchName": "renovate/slf4j-monorepo"
                   }
                 ],
                 "packageName": "org.slf4j:slf4j-api",
                 "versioning": "maven",
                 "warnings": [],
                 "sourceUrl": "https://github.com/qos-ch/slf4j",
                 "registryUrl": "https://repo.maven.apache.org/maven2",
                 "homepage": "http://www.slf4j.org",
                 "changelogUrl": "https://www.slf4j.org/news.html",
                 "currentVersion": "2.0.12",
                 "isSingleVersion": true,
                 "fixedVersion": "2.0.12"
               }
             ]
           }
         ],
         "sbt": [
           {
             "deps": [
               {
                 "datasource": "sbt-package",
                 "depName": "org.slf4j:slf4j-api",
                 "packageName": "org.slf4j:slf4j-api",
                 "currentValue": "2.0.12",
                 "groupName": "slf4jVersion",
                 "variableName": "slf4jVersion",
                 "registryUrls": ["https://repo1.maven.org/maven2"],
                 "updates": [
                   {
                     "bucket": "non-major",
                     "newVersion": "2.0.13",
                     "newValue": "2.0.13",
                     "newMajor": 2,
                     "newMinor": 0,
                     "updateType": "patch",
                     "branchName": "renovate/slf4jversion"
                   }
                 ],
                 "versioning": "ivy",
                 "warnings": [],
                 "registryUrl": "https://repo1.maven.org/maven2",
                 "homepage": "http://www.slf4j.org",
                 "dependencyUrl": "https://repo1.maven.org/maven2/org/slf4j",
                 "currentVersion": "2.0.12",
                 "isSingleVersion": true,
                 "fixedVersion": "2.0.12"
               }
             ],
             "packageFile": "build.sbt"
           }
         ]
       }

So it seems that your assessment was right. Renovate is not producing the same results/URLs from the same pom source.

[gaeljw]

Thanks for the check and confirmation 🙏

[rarkins]

Converted to issue: #28491