404 (Not Found) when updating a PR on Gitea

[ronaldvb-k]

What would you like help with?

I think I found a bug

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Gitea, renovate:37.281.4

Please tell us more about your question or problem

Renovate tries to update a Pull Request which does not exist (anymore) and fails with a 404 (Not Found) error.
The corresponding branch still exists in Gitea.

The pull request exists in the Renovate json prcache, but not in Gitea. It looks like the cache should be invalidated at this point?

Please let me know if you need more information.

Logs (if relevant)

Select me to see logs

{"name":"renovate","hostname":"renovate-bot-manual-gzj8j","pid":8,"level":30,"logContext":"HsCdK6hHht9_rJSjhw4lt","length":1,"repositories":["kss/kss-deploy"],"msg":"Autodiscovered repositories","time":"2024-04-17T06:59:57.921Z","v":0}
{"name":"renovate","hostname":"renovate-bot-manual-gzj8j","pid":8,"level":30,"logContext":"HsCdK6hHht9_rJSjhw4lt","repository":"kss/kss-deploy","renovateVersion":"37.281.4","msg":"Repository started","time":"2024-04-17T07:01:59.522Z","v":0}
{"name":"renovate","hostname":"renovate-bot-manual-gzj8j","pid":8,"level":30,"logContext":"HsCdK6hHht9_rJSjhw4lt","repository":"kss/kss-deploy","baseBranch":"develop","stats":{"managers":{"helmv3":{"fileCount":12,"depCount":12}},"total":{"fileCount":12,"depCount":12}},"msg":"Dependency extraction complete","time":"2024-04-17T07:02:01.667Z","v":0}
{"name":"renovate","hostname":"renovate-bot-manual-gzj8j","pid":8,"level":50,"logContext":"HsCdK6hHht9_rJSjhw4lt","repository":"kss/kss-deploy","branch":"renovate/traefik-1.x","err":{"name":"HTTPError","code":"ERR_NON_2XX_3XX_RESPONSE","timings":{"start":1713337321879,"socket":1713337321880,"lookup":1713337321881,"connect":1713337321883,"secureConnect":1713337321887,"upload":1713337321887,"response":1713337321923,"end":1713337321923,"phases":{"wait":1,"dns":1,"tcp":2,"tls":4,"request":0,"firstByte":36,"download":0,"total":44}},"message":"Response code 404 (Not Found)","stack":"HTTPError: Response code 404 (Not Found)\n    at Request.<anonymous> (/usr/local/renovate/node_modules/.pnpm/got@11.8.6/node_modules/got/dist/source/as-promise/index.js:118:42)\n    at processTicksAndRejections (node:internal/process/task_queues:95:5)","options":{"headers":{"user-agent":"RenovateBot/37.281.4 (https://github.com/renovatebot/renovate)","accept":"application/json","authorization":"***********","content-type":"application/json","content-length":"952","accept-encoding":"gzip, deflate, br"},"url":"https://XXX/api/v1/repos/kss/kss-deploy/pulls/429","hostType":"gitea","username":"","password":"","method":"PATCH","http2":false},"response":{"statusCode":404,"statusMessage":"Not Found","body":{"errors":null,"message":"The target couldn't be found.","url":"https://XXX/api/swagger"},"headers":{"cache-control":"max-age=0, private, must-revalidate, no-transform","content-length":"112","content-type":"application/json;charset=utf-8","date":"Wed, 17 Apr 2024 07:02:01 GMT","x-content-type-options":"nosniff","x-frame-options":"SAMEORIGIN","connection":"close","strict-transport-security":"max-age=31536000; includeSubDomains; preload"},"httpVersion":"1.1","retryCount":0}},"msg":"Failed to ensure PR: Update Helm release traefik to ~1.3.0","time":"2024-04-17T07:02:01.925Z","v":0}
{"name":"renovate","hostname":"renovate-bot-manual-gzj8j","pid":8,"level":30,"logContext":"HsCdK6hHht9_rJSjhw4lt","repository":"kss/kss-deploy","durationMs":1117,"msg":"git fetch completed","time":"2024-04-17T07:02:03.340Z","v":0}
{"name":"renovate","hostname":"renovate-bot-manual-gzj8j","pid":8,"level":30,"logContext":"HsCdK6hHht9_rJSjhw4lt","repository":"kss/kss-deploy","branchName":"renovate/argocd-1.x","prNo":422,"prTitle":"Update Helm release argocd to ~1.9.0","msg":"Autoclosing PR","time":"2024-04-17T07:02:03.358Z","v":0}
{"name":"renovate","hostname":"renovate-bot-manual-gzj8j","pid":8,"level":40,"logContext":"HsCdK6hHht9_rJSjhw4lt","repository":"kss/kss-deploy","err":{"name":"HTTPError","code":"ERR_NON_2XX_3XX_RESPONSE","timings":{"start":1713337323360,"socket":1713337323361,"lookup":1713337323366,"connect":1713337323369,"secureConnect":1713337323371,"upload":1713337323371,"response":1713337323426,"end":1713337323426,"phases":{"wait":1,"dns":5,"tcp":3,"tls":2,"request":0,"firstByte":55,"download":0,"total":66}},"message":"Response code 404 (Not Found)","stack":"HTTPError: Response code 404 (Not Found)\n    at Request.<anonymous> (/usr/local/renovate/node_modules/.pnpm/got@11.8.6/node_modules/got/dist/source/as-promise/index.js:118:42)\n    at processTicksAndRejections (node:internal/process/task_queues:95:5)","options":{"headers":{"user-agent":"RenovateBot/37.281.4 (https://github.com/renovatebot/renovate)","accept":"application/json","authorization":"***********","content-type":"application/json","content-length":"82","accept-encoding":"gzip, deflate, br"},"url":"https://XXX/api/v1/repos/kss/kss-deploy/pulls/422","hostType":"gitea","username":"","password":"","method":"PATCH","http2":false},"response":{"statusCode":404,"statusMessage":"Not Found","body":{"errors":null,"message":"The target couldn't be found.","url":"https://XXX/api/swagger"},"headers":{"cache-control":"max-age=0, private, must-revalidate, no-transform","content-length":"112","content-type":"application/json;charset=utf-8","date":"Wed, 17 Apr 2024 07:02:03 GMT","x-content-type-options":"nosniff","x-frame-options":"SAMEORIGIN","connection":"close","strict-transport-security":"max-age=31536000; includeSubDomains; preload"},"httpVersion":"1.1","retryCount":0}},"branch":"renovate/argocd-1.x","msg":"Error pruning branch","time":"2024-04-17T07:02:03.427Z","v":0}
{"name":"renovate","hostname":"renovate-bot-manual-gzj8j","pid":8,"level":30,"logContext":"HsCdK6hHht9_rJSjhw4lt","repository":"kss/kss-deploy","cloned":true,"durationMs":3906,"msg":"Repository finished","time":"2024-04-17T07:02:03.429Z","v":0}
{"name":"renovate","hostname":"renovate-bot-manual-gzj8j","pid":8,"level":30,"logContext":"HsCdK6hHht9_rJSjhw4lt","msg":"Renovate was run at log level \"info\". Set LOG_LEVEL=debug in environment variables to see extended debug logs.","time":"2024-04-17T07:02:14.523Z","v":0}
{"name":"renovate","hostname":"renovate-bot-manual-gzj8j","pid":8,"level":30,"logContext":"HsCdK6hHht9_rJSjhw4lt","loggerErrors":[{"name":"renovate","level":50,"logContext":"HsCdK6hHht9_rJSjhw4lt","repository":"kss/kss-deploy","branch":"renovate/traefik-1.x","err":{"name":"HTTPError","code":"ERR_NON_2XX_3XX_RESPONSE","timings":{"start":1713337321879,"socket":1713337321880,"lookup":1713337321881,"connect":1713337321883,"secureConnect":1713337321887,"upload":1713337321887,"response":1713337321923,"end":1713337321923,"phases":{"wait":1,"dns":1,"tcp":2,"tls":4,"request":0,"firstByte":36,"download":0,"total":44}},"message":"Response code 404 (Not Found)","stack":"HTTPError: Response code 404 (Not Found)\n    at Request.<anonymous> (/usr/local/renovate/node_modules/.pnpm/got@11.8.6/node_modules/got/dist/source/as-promise/index.js:118:42)\n    at processTicksAndRejections (node:internal/process/task_queues:95:5)","options":{"headers":{"user-agent":"RenovateBot/37.281.4 (https://github.com/renovatebot/renovate)","accept":"application/json","authorization":"***********","content-type":"application/json","content-length":"952","accept-encoding":"gzip, deflate, br"},"url":"https://XXX/api/v1/repos/kss/kss-deploy/pulls/429","hostType":"gitea","username":"","password":"","method":"PATCH","http2":false},"response":{"statusCode":404,"statusMessage":"Not Found","body":{"errors":null,"message":"The target couldn't be found.","url":"https://XXX/api/swagger"},"headers":{"cache-control":"max-age=0, private, must-revalidate, no-transform","content-length":"112","content-type":"application/json;charset=utf-8","date":"Wed, 17 Apr 2024 07:02:01 GMT","x-content-type-options":"nosniff","x-frame-options":"SAMEORIGIN","connection":"close","strict-transport-security":"max-age=31536000; includeSubDomains; preload"},"httpVersion":"1.1","retryCount":0}},"msg":"Failed to ensure PR: Update Helm release traefik to ~1.3.0"}],"msg":"Renovate is exiting with a non-zero code due to the following logged errors","time":"2024-04-17T07:02:14.524Z","v":0}

[github-actions[bot]]

Hi there,

This issue or discussion is missing some logs, making it difficult or impossible to help you. Depending on which situation applies follow one, some or all of these instructions.

No logs at all

If you haven't posted any log yet, we need you to find and copy/paste the log into the issue template.

Finding logs on hosted app

Select me to read instructions

If you use the Mend Renovate app (GitHub):

1. Log in to the Mend Developer Portal
2. Navigate to the correct organization and repository
3. Locate the appropriate log (it may not always be the latest one)
4. Copy/paste the log contents
5. Follow the steps in the formatting your logs section

Finding logs when self-hosting

Select me to read instructions

Read the Renovate docs, troubleshooting, self-hosted to learn how to find the logs.

Insufficient logs

Select me to read instructions

If you already gave us a log, and the Renovate team said it's not enough, then follow the instructions from the No logs at all section.

Formatting your logs

Select me to read instructions

Please put your logs in a <details> and <summary> element like this:

<details><summary>Select me to see logs</summary>

```
Copy/paste your logs here, between the starting and ending backticks
```

</details>

If you feel the logs are too large to paste here, please use a service like GitHub Gist and paste the link here.

Good luck,

The Renovate team

[ronaldvb-k]

Added all the logging i have for now.

[rarkins]

These are not debug logs

[ronaldvb-k]

Added debug logging & decoded Renovate cache json file: https://gist.github.com/ronaldvb-k/2c0d2bcca4c8ec1ff6d3c5c1f98197a2

How to reproduce:

1. Create git repository with a simple Dockerfile with: FROM renovate/renovate:37.301.6.
2. Let Renovate run, branch & PR are created by Renovate.
3. Delete the PR, but keep the branch.
4. Let Renovate run until there is a new Renovate docker image is available, in this example: renovate/renovate:37.303.0.
5. Renovate updates the branch successfully.
6. Renovate tries to update (PATCH) the PR, but fails because the PR is deleted. References to the deleted PR still exists inside the Renovate json cache file.

Renovate should invalidate the cache an re-create the PR?

[rarkins]

@ronaldvb-k thanks for this analysis.

Do you think this is the line where it starts going wrong?

{"name":"renovate","hostname":"renovate-bot-renovate-404-test-manual5-qrgfm","pid":8,"level":20,"logContext":"mMAXstpl3C52Tr69vuwmh","repository":"renovate-404-test/renovate-404-test","msg":"findPr(renovate/renovate-renovate-37.x, undefined, open)","time":"2024-04-17T11:51:20.125Z","v":0}
{"name":"renovate","hostname":"renovate-bot-renovate-404-test-manual5-qrgfm","pid":8,"level":20,"logContext":"mMAXstpl3C52Tr69vuwmh","repository":"renovate-404-test/renovate-404-test","msg":"Found PR #2","time":"2024-04-17T11:51:20.125Z","v":0}

i.e. it's looking for an open PR for this branch, and returns #2. Is that the PR which is actually closed?

[ronaldvb-k]

Yes i do think so.

The PR was #2 but has been deleted by the user, so it now returns a 404.

A workaround for this issue is to set the RENOVATE_REPOSITORY_CACHE from enabled to reset. Renovate will bypass the cache and creates a new PR in gitea.