misunderstanding of semantic commits

[echoix]

What would you like help with?

I think I found a bug

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

Recently, about 3 hours ago, PRs that get rebased by renovate, have their titles changed to another convention not respecting the renovate.json in the repo. Our release workflows expect a certain naming convention.

I identified two three situations that got renamed titles:

• On ticking retry/rebase the PR, the title changes.
• On automatic rebasing (without user ticking the retry/rebase checkbox)
• (after further investigation): a completely new PR opened on my fork of the same project, did not follow the naming convention of the repo (about 4 hours ago).

Logs (if relevant)

Logs and config

Config file:

{
    "$schema": "https://docs.renovatebot.com/renovate-schema.json",
    "extends": [
        "config:best-practices",
        ":semanticCommitTypeAll(CI)"
    ]
}

DEBUG: Fetching changelog: https://github.com/actions/upload-artifact (v4.3.1 -> v4.3.2) (branch="renovate/actions-upload-artifact-4.x")
DEBUG: Fetching changelog: https://github.com/actions/upload-artifact (v4.3.1 -> v4.3.2) (branch="renovate/actions-upload-artifact-4.x")
DEBUG: Processing existing PR (branch="renovate/actions-upload-artifact-4.x")
DEBUG: PR title changed (branch="renovate/actions-upload-artifact-4.x")
{
  "branchName": "renovate/actions-upload-artifact-4.x"
  "oldPrTitle": "CI(deps): Update actions/upload-artifact action to v4.3.2"
  "newPrTitle": "Update actions/upload-artifact action to v4.3.2"
}

DEBUG: updatePr(3625, Update actions/upload-artifact action to v4.3.2, body) (branch="renovate/actions-upload-artifact-4.x")
DEBUG: PR updated...prNo: 3625 (branch="renovate/actions-upload-artifact-4.x")
INFO: PR updated (branch="renovate/actions-upload-artifact-4.x")
{
  "pr": 3625
  "prTitle": "Update actions/upload-artifact action to v4.3.2"
}

DEBUG: setPrCache() (branch="renovate/actions-upload-artifact-4.x")
DEBUG: PR is not configured for automerge (branch="renovate/actions-upload-artifact-4.x")
DEBUG: setBranchCommit() (branch="renovate/actions-upload-artifact-4.x")
DEBUG: syncBranchState() (branch="renovate/github-codeql-action-3.x")
DEBUG: syncBranchState(): update baseBranchSha (branch="renovate/github-codeql-action-3.x")
DEBUG: branch.isUpToDate(): using cached result "true" (branch="renovate/github-codeql-action-3.x")

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

To get started, please read our guide on creating a minimal reproduction.

Good luck,

The Renovate team

[echoix]

Not an issue anymore

[echoix]

Renovate is still renaming PRs to the wrong naming convention, against the repo's convention, and even after manual renaming and squash merge activated

[HonkingGoose]

@HonkingGoose Thanks a lot,your intuition makes sense! Is this a kind of issue the renovate config validator can catch, at least when trying out the new config. Either way, I didn't know that you could ignore presets like this.

You're welcome! ❤️ I don't know if the Renovate config validator can catch these kinds of problems. I'll let a maintainer answer that.

At least you learned about a new config option. 🙃

From the first link you pointed to, maybe the culprit is the fact that it looks at the last 10 commits in the base branch, thus why it seemed intermittent, as the project isn't an all-in conventional commit style, but is based on prefixing with many different modules, that might or might not be mistaken as conventional commits. I find it weird though that the same config being used for more than a year without having this issue. Maybe the layering rules changed since?

I doubt the problem is with your config, as it used to work fine for a year. Unless we changed the layering/order of operation recently, as you said. I'll let a maintainer respond though, as I'm well out of my depth now. 😉

[HonkingGoose]

I do not know if we ended up with the correct diagnosis, and solution... 😄

@rarkins can you please review the discussion and:

• Tell us if my ideas are good/bad.
• Whether you want the Renovate config validator to catch this issue, if that's even possible.
• What you think is the cause of the problems:
  • Order in which the presets are listed?
  • Is the ":semanticPrefixFixDepsChoreOthers", part of the config:recommend preset conflicting with the ":semanticCommitTypeAll(CI)" preset in some way?
    • Should the user ignore the ":semanticCommitTypeAll(CI)" preset by putting it in a ignorePresets box?
  • Renovate is reading the last 10 commits on the base branch, which somehow causes problems when rebasing a Renovate PR branch?
• Anything else that is important here?

[echoix]

The PRs opened recently were already with the wrong title. So the rebase doesn't seem part of the symptoms, it seems only when an action is made to update the PR that it has a change.

[rarkins]

The title/premise of this discussion is wrong, I don't think there's any more to look into.

If you don't configure it explicitly, renovate will "guess" your semantic commits use based on the last 10 commits. This is a feature and not a bug.

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

To get started, please read our guide on creating a minimal reproduction.

Good luck,

The Renovate team