allowedHeaders in config.js seems to be ignored

[pfaelzerchen]

What would you like help with?

I think I found a bug

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Kubernetes with Helm chart

Please tell us more about your question or problem

I'm having the problem described in issue #26983 which should be fixed since 37.279.2, but for me is still present in 37.314.0.

The log file shows:

DEBUG: File config
       "config": {
         "allowedHeaders": ["X-*"],
         "platform": "gitea",
         "endpoint": "https://git.host.tld/api/v1",
         "gitAuthor": "Renovate Bot <renovate@host.tld>",
         "autodiscover": true,
         "dryRun": null,
         "printConfig": true,
         "extends": ["config:recommended", ":disableRateLimiting"],
         "hostRules": [
           {"enableHttp2": true},
           {
             "matchHost": "https://git.host.tld",
             "enableHttp2": true,
             "headers": {
               "X-custom-header": "abc"
             }
           }
         ],
         "assignees": ["user"],
         "reviewers": ["user"]
       }
...
ERROR: Disallowed hostRules headers
       "allowedHeaders": [],
       "header": "X-custom-header"

So, for some reason, the allowedHeaders configuration is ignored. It is the same when I use RENOVATE_ALLOWED_HEADERS in the environment. Even omitting should work according to the docs as X-* is renovate's default.

Is there still a bug present or is there something wrong with my configs?

Logs (if relevant)

Logs

DEBUG: Using RE2 regex engine
DEBUG: Parsing configs
DEBUG: Checking for config file in /usr/src/app/config.json
DEBUG: Converting GITHUB_COM_TOKEN into a global host rule
DEBUG: File config
       "config": {
         "allowedHeaders": ["X-*"],
         "platform": "gitea",
         "endpoint": "https://git.domain.tld/api/v1",
         "gitAuthor": "Renovate Bot <renovate@domain.tld>",
         "autodiscover": true,
         "dryRun": null,
         "printConfig": true,
         "extends": ["config:recommended", ":disableRateLimiting"],
         "hostRules": [
           {"enableHttp2": true},
           {
             "matchHost": "https://git.domain.tld",
             "enableHttp2": true,
             "headers": {
               "X-custom-header": "abc"
             }
           }
         ],
         "assignees": ["matthias"],
         "reviewers": ["matthias"]
       }
DEBUG: CLI config
       "config": {}
DEBUG: Env config
       "config": {
         "hostRules": [
           {"hostType": "github", "matchHost": "github.com", "token": "***********"}
         ],
         "redisUrl": "redis://renovate-redis-master",
         "token": "***********"
       }
DEBUG: Combined config
       "config": {
         "allowedHeaders": ["X-*"],
         "platform": "gitea",
         "endpoint": "https://git.domain.tld/api/v1",
         "gitAuthor": "Renovate Bot <renovate@domain.tld>",
         "autodiscover": true,
         "dryRun": null,
         "printConfig": true,
         "extends": ["config:recommended", ":disableRateLimiting"],
         "hostRules": [
           {"enableHttp2": true},
           {
             "matchHost": "https://git.domain.tld",
             "enableHttp2": true,
             "headers": {
               "X-custom-header": "abc"
             }
           },
           {"hostType": "github", "matchHost": "github.com", "token": "***********"}
         ],
         "assignees": ["matthias"],
         "reviewers": ["matthias"],
         "redisUrl": "redis://renovate-redis-master",
         "token": "***********"
       }
DEBUG: Adding trailing slash to endpoint
DEBUG: Found valid git version: 2.43.2
DEBUG: Setting global hostRules
DEBUG: Adding token authentication for github.com (hostType=github) to hostRules
DEBUG: hostRules: authentication already set for git.domain.tld
DEBUG: Using configured gitAuthor (Renovate Bot <renovate@domain.tld>)
DEBUG: Adding token authentication for git.domain.tld (hostType=gitea) to hostRules
DEBUG: Using baseDir: /tmp/renovate
DEBUG: Using cacheDir: /tmp/renovate/cache
DEBUG: Using containerbaseDir: /tmp/renovate/cache/containerbase
DEBUG: Redis cache init
DEBUG: Commits limit = null
DEBUG: Setting global hostRules
DEBUG: Adding token authentication for github.com (hostType=github) to hostRules
DEBUG: Adding token authentication for git.domain.tld (hostType=gitea) to hostRules
DEBUG: validatePresets()
DEBUG: Auto-discovering Gitea repositories
DEBUG: hostRules: applying Bearer authentication for git.domain.tld
ERROR: Disallowed hostRules headers
       "allowedHeaders": [],
       "header": "X-custom-header"

[rarkins]

Which version of renovate are you running?

[pfaelzerchen]

The last run was with versions: 37.314.0 and 37.315.0

[rarkins]

Please provide full debug logs from startup to when the error occurs

[pfaelzerchen]

I added a fresh run to the description. This time with version 37.318.0

[rarkins]

I think this might be related to the fact that this is your gitea endpoint. I don't get far enough along on try.gitea.io to reproduce it. @viceice can you reproduce?

[viceice]

I can try tomorrow

[github-actions[bot]]

Hi there,

This issue or discussion is missing some logs, making it difficult or impossible to help you. Depending on which situation applies follow one, some or all of these instructions.

No logs at all

If you haven't posted any log yet, we need you to find and copy/paste the log into the issue template.

Finding logs on hosted app

Select me to read instructions

If you use the Mend Renovate app (GitHub):

1. Log in to the Mend Developer Portal
2. Navigate to the correct organization and repository
3. Locate the appropriate log (it may not always be the latest one)
4. Copy/paste the log contents
5. Follow the steps in the formatting your logs section

Finding logs when self-hosting

Select me to read instructions

Read the Renovate docs, troubleshooting, self-hosted to learn how to find the logs.

Insufficient logs

Select me to read instructions

If you already gave us a log, and the Renovate team said it's not enough, then follow the instructions from the No logs at all section.

Formatting your logs

Select me to read instructions

Please put your logs in a <details> and <summary> element like this:

<details><summary>Select me to see logs</summary>

```
Copy/paste your logs here, between the starting and ending backticks
```

</details>

If you feel the logs are too large to paste here, please use a service like GitHub Gist and paste the link here.

Good luck,

The Renovate team