PNPM overrides completely break renovate updates

[Algram]

What would you like help with?

I think I found a bug

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

Hello,

during the implementation of the pnpm.overrides support in the package.json, the following PR was incomplete: #28199

The PR enables parsing of the overrides, but can not update them, because the enum which handles this (NPMDepType) has not been updated:

renovate/lib/modules/manager/npm/update/dependency/index.ts

Line 162 in 5c0628b

oldVersion = parsedContents[depType as NpmDepType]![depName] as string;

This means as soon as renovate tries to update a dependency which also is defined in pnpm.overrides, it breaks because it actually tries to write to just overrides in the package.json.

I have added our log output down below. If you have any further questions feel free to ask them. In the meantime it would be great if you could revert this faulty PR at least for the Mend application, since we have no option to specify or downgrade a version there. Until then our dependency updates will be broken.

Logs (if relevant)

Logs

DEBUG: updateDependency error (branch="renovate/all-minor-patch")
{
  "baseBranch": "main"
  "err": {
    "message": "Cannot read properties of undefined (reading '@typescript-eslint/eslint-plugin')",
    "stack": "TypeError: Cannot read properties of undefined (reading '@typescript-eslint/eslint-plugin')\n    at updateDependency (/usr/local/renovate/lib/modules/manager/npm/update/dependency/index.ts:162:58)\n    at getUpdatedPackageFiles (/usr/local/renovate/lib/workers/repository/update/branch/get-updated.ts:221:30)\n    at processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at processBranch (/usr/local/renovate/lib/workers/repository/update/branch/index.ts:460:19)\n    at writeUpdates (/usr/local/renovate/lib/workers/repository/process/write.ts:166:17)\n    at update (/usr/local/renovate/lib/workers/repository/process/extract-update.ts:214:11)\n    at Object.renovateRepository (/usr/local/renovate/lib/workers/repository/index.ts:87:19)\n    at attributes.repository (/usr/local/renovate/lib/workers/global/index.ts:217:11)\n    at start (/usr/local/renovate/lib/workers/global/index.ts:202:7)\n    at /usr/local/renovate/lib/renovate.ts:18:22"
  }
}

DEBUG: Error updating file (branch="renovate/all-minor-patch")

[viceice]

Looking into it

[viceice]

Found it 💪

• fix(npm): replace pnpm overrides in right position #28606

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

To get started, please read our guide on creating a minimal reproduction.

Good luck,

The Renovate team

[viceice]

We need a reproduction. i can't find any obvious issue in code. It should use this block for overrides

renovate/lib/modules/manager/npm/update/dependency/index.ts

Lines 147 to 160 in 01d4d0d

	} else if (isOverrideObject(upgrade)) {
	overrideDepParents = managerData?.parents;
	if (overrideDepParents) {
	// old version when there is an object as a value in overrides block
	const { depObjectReference, overrideDepName } = overrideDepPosition(
	parsedContents['overrides']!,
	overrideDepParents,
	depName,
	);
	if (depObjectReference) {
	oldVersion = depObjectReference[overrideDepName]!;
	}
	}
	} else {

[viceice]

@Algram Can you plrease create a reproduction or point me to a public repo where it happens?

[viceice]

nevermind, was able to reproduce myself