Renovate clobbers over ratchet comment, while docs says it should keep it #28617
Answered
by
HonkingGoose
HonkingGoose
asked this question in
Request Help
-
What would you like help with?I think I found a bug How are you running Renovate?Mend hosted GitHub app If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.No response Please tell us more about your question or problemRenovate clobbers over the I was inspired to try to reproduce the problem mentioned in this comment: Expected update: - uses: "actions/setup-java@387ac29b308b003ca37ba93a6cab5eb57c8f5f93" # ratchet:actions/setup-java@v4
+ uses: "actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9" # ratchet:actions/setup-java@v4 Actual update: - uses: "actions/setup-java@387ac29b308b003ca37ba93a6cab5eb57c8f5f93" # ratchet:actions/setup-java@v4
+ uses: "actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9" # v4 Note how Renovate strips the Renovate config: {
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["config:best-practices"]
} GitHub Actions file: name: test
on:
push:
branches: [main]
pull_request:
branches: [main]
permissions:
contents: read
jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [20.x]
steps:
- name: checkout repository
uses: actions/checkout@v4
- name: Set up Java
uses: "actions/setup-java@387ac29b308b003ca37ba93a6cab5eb57c8f5f93" # ratchet:actions/setup-java@v4
with:
java-version: "21"
distribution: "temurin" Reproduction repository PR: Logs (if relevant)Logs
The docs say:
|
Beta Was this translation helpful? Give feedback.
Answered by
HonkingGoose
Apr 25, 2024
Replies: 1 comment 3 replies
-
seems the feature isn't fully implemented 🤷♂️ |
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I created the issue for us, and forked the reproduction into our reproduction organization:
renovate-reproductions/28645