reviewersSampleSize not taken into account

[deronnax]

What would you like help with?

I think I found a bug

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Gitlab, Renovate 37.227.2

Please tell us more about your question or problem

Hello.
First of all, thank you again for Renovate, much appreciated.
I wrote a package rules configuration to assign particular Gitlab Teams to particular packages managers. The config can be summed up to this:

{  
  extends: ['config:recommended'],
  enabledManagers: ['pep621', 'npm'],
  reviewersSampleSize: 1,
  packageRules: [
    {
      matchManagers: ['pep621'],
      reviewers: ['@orga/team-backend'],
    },
    {
      matchManagers: ['npm'],
      reviewers: ['@orga/team-frontend'],
    },
  ]
}

The team are correctly expanded, but the reviewersSampleSize is not taken into account: every people of the team are set as reviewers.

Logs (if relevant)

Logs

Replace this text with your logs, between the starting and ending triple backticks

[github-actions[bot]]

Hi there,

This issue or discussion is missing some logs, making it difficult or impossible to help you. Depending on which situation applies follow one, some or all of these instructions.

No logs at all

If you haven't posted any log yet, we need you to find and copy/paste the log into the issue template.

Finding logs on hosted app

Select me to read instructions

If you use the Mend Renovate app (GitHub):

1. Log in to the Mend Developer Portal
2. Navigate to the correct organization and repository
3. Locate the appropriate log (it may not always be the latest one)
4. Copy/paste the log contents
5. Follow the steps in the formatting your logs section

Finding logs when self-hosting

Select me to read instructions

Read the Renovate docs, troubleshooting, self-hosted to learn how to find the logs.

Insufficient logs

Select me to read instructions

If you already gave us a log, and the Renovate team said it's not enough, then follow the instructions from the No logs at all section.

Formatting your logs

Select me to read instructions

Please put your logs in a <details> and <summary> element like this:

<details><summary>Select me to see logs</summary>

```
Copy/paste your logs here, between the starting and ending backticks
```

</details>

If you feel the logs are too large to paste here, please use a service like GitHub Gist and paste the link here.

Good luck,

The Renovate team

[deronnax]

I don't think logs are relevant for this case.

[deronnax]

@rarkins sorry to ping you directly, but I think this question has been unfairly overlooked and doesn't need logs to be grasped. Can you tell me if you think so too? If I am wrong, I will try to extract what would look like a relevant portion of logs for this problem.
Thank you very much 🙏

[rarkins]

Maybe the logs won't help much, but if it's not important enough for you to try, it's not important enough for us to try