renovate fails to update sha256 hash for Bazel dependency #28650

avdv · 2024-04-25T12:27:58Z

avdv
Apr 25, 2024

What would you like help with?

I think I found a bug

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

renovate created this PR: tweag/rules_sh#83 but somehow it failed to replace the old sha256 hash with the new one:

diff --git a/bzlmod/extensions.bzl b/bzlmod/extensions.bzl
index b7fdd6f..4641127 100644
--- a/bzlmod/extensions.bzl
+++ b/bzlmod/extensions.bzl
@@ -64,7 +64,7 @@ def _sh_configure_impl(module_ctx):
     http_file(
         name = "rules_sh_shim_exe",
         sha256 = "cb440b8a08a2095a59666a859b35aa5a1524b140b909ecc760f38f3baccf80e6",
-        urls = ["https://github.com/ScoopInstaller/Shim/releases/download/v1.0.1/shim.exe"],
+        urls = ["https://github.com/ScoopInstaller/Shim/releases/download/v1.1.0/shim.exe"],
         downloaded_file_path = "shim.exe",
         executable = True,
     )
diff --git a/sh/repositories.bzl b/sh/repositories.bzl
index 0ec6898..886891f 100644
--- a/sh/repositories.bzl
+++ b/sh/repositories.bzl
@@ -46,7 +46,7 @@ def rules_sh_dependencies():
         http_file,
         name = "rules_sh_shim_exe",
         sha256 = "cb440b8a08a2095a59666a859b35aa5a1524b140b909ecc760f38f3baccf80e6",
-        urls = ["https://github.com/ScoopInstaller/Shim/releases/download/v1.0.1/shim.exe"],
+        urls = ["https://github.com/ScoopInstaller/Shim/releases/download/v1.1.0/shim.exe"],
         downloaded_file_path = "shim.exe",
         executable = True,
     )

Logs (if relevant)

Logs

DEBUG: 2 flattened updates found: rules_sh_shim_exe, rules_sh_shim_exe
DEBUG: Returning 1 branch(es)
DEBUG: config.repoIsOnboarded=true
DEBUG: packageFiles with updates
{
  "baseBranch": "master"
  "config": {
    "bazel": [
      {
        "deps": [
          {
            "currentValue": "v1.0.1",
            "currentVersion": "v1.0.1",
            "datasource": "github-releases",
            "depName": "rules_sh_shim_exe",
            "depType": "http_file",
            "fixedVersion": "v1.0.1",
            "isSingleVersion": true,
            "managerData": {
              "idx": 0
            },
            "packageName": "ScoopInstaller/Shim",
            "registryUrl": "https://github.com",
            "sourceUrl": "https://github.com/ScoopInstaller/Shim",
            "versioning": "semver-coerced",
            "warnings": [],
            "updates": [
              {
                "bucket": "non-major",
                "newVersion": "v1.1.0",
                "newValue": "v1.1.0",
                "releaseTimestamp": "2024-04-17T07:49:56.000Z",
                "newMajor": 1,
                "newMinor": 1,
                "updateType": "minor",
                "branchName": "renovate/rules_sh_shim_exe-1.x"
              }
            ]
          }
        ],
        "packageFile": "bzlmod/extensions.bzl"
      },
      {
        "deps": [
          {
            "currentValue": "1.6.0",
            "currentVersion": "1.6.0",
            "datasource": "github-releases",
            "depName": "bazel_skylib",
            "depType": "http_archive",
            "fixedVersion": "1.6.0",
            "managerData": {
              "idx": 0
            },
            "packageName": "bazelbuild/bazel-skylib",
            "registryUrl": "https://github.com",
            "sourceUrl": "https://github.com/bazelbuild/bazel-skylib",
            "versioning": "semver-coerced",
            "warnings": [],
            "updates": []
          },
          {
            "currentValue": "0.0.9",
            "currentVersion": "0.0.9",
            "datasource": "github-releases",
            "depName": "platforms",
            "depType": "http_archive",
            "fixedVersion": "0.0.9",
            "managerData": {
              "idx": 1
            },
            "packageName": "bazelbuild/platforms",
            "registryUrl": "https://github.com",
            "sourceUrl": "https://github.com/bazelbuild/platforms",
            "versioning": "semver-coerced",
            "warnings": [],
            "updates": []
          },
          {
            "currentValue": "v1.0.1",
            "currentVersion": "v1.0.1",
            "datasource": "github-releases",
            "depName": "rules_sh_shim_exe",
            "depType": "http_file",
            "fixedVersion": "v1.0.1",
            "isSingleVersion": true,
            "managerData": {
              "idx": 2
            },
            "packageName": "ScoopInstaller/Shim",
            "registryUrl": "https://github.com",
            "sourceUrl": "https://github.com/ScoopInstaller/Shim",
            "versioning": "semver-coerced",
            "warnings": [],
            "updates": [
              {
                "bucket": "non-major",
                "newVersion": "v1.1.0",
                "newValue": "v1.1.0",
                "releaseTimestamp": "2024-04-17T07:49:56.000Z",
                "newMajor": 1,
                "newMinor": 1,
                "updateType": "minor",
                "branchName": "renovate/rules_sh_shim_exe-1.x"
              }
            ]
          }
        ],
        "packageFile": "sh/repositories.bzl"
      }
    ],
    "bazel-module": [
      {
        "deps": [
          {
            "currentValue": "1.2.1",
            "datasource": "bazel",
            "depName": "bazel_skylib",
            "depType": "bazel_dep",
            "packageName": "bazel_skylib",
            "skipReason": "disabled",
            "updates": []
          },
          {
            "currentValue": "0.0.8",
            "datasource": "bazel",
            "depName": "platforms",
            "depType": "bazel_dep",
            "packageName": "platforms",
            "skipReason": "disabled",
            "updates": []
          },
          {
            "currentValue": "0.6.2",
            "datasource": "bazel",
            "depName": "stardoc",
            "depType": "bazel_dep",
            "packageName": "stardoc",
            "skipReason": "disabled",
            "updates": []
          }
        ],
        "packageFile": "MODULE.bazel"
      },
      {
        "deps": [
          {
            "currentValue": "0.4.0",
            "datasource": "bazel",
            "depName": "rules_sh",
            "depType": "bazel_dep",
            "packageName": "rules_sh",
            "skipReason": "local-dependency",
            "updates": []
          },
          {
            "depName": "rules_sh",
            "depType": "local_path_override",
            "packageName": "rules_sh",
            "skipReason": "unsupported-datasource",
            "updates": []
          },
          {
            "currentValue": "1.6.0",
            "currentVersion": "1.6.0",
            "datasource": "bazel",
            "depName": "bazel_skylib",
            "depType": "bazel_dep",
            "fixedVersion": "1.6.0",
            "packageName": "bazel_skylib",
            "registryUrl": "https://raw.githubusercontent.com/bazelbuild/bazel-central-registry/main",
            "versioning": "bazel-module",
            "warnings": [],
            "updates": []
          },
          {
            "currentValue": "0.0.9",
            "currentVersion": "0.0.9",
            "datasource": "bazel",
            "depName": "platforms",
            "depType": "bazel_dep",
            "fixedVersion": "0.0.9",
            "packageName": "platforms",
            "registryUrl": "https://raw.githubusercontent.com/bazelbuild/bazel-central-registry/main",
            "versioning": "bazel-module",
            "warnings": [],
            "updates": []
          },
          {
            "currentValue": "0.6.2",
            "currentVersion": "0.6.2",
            "datasource": "bazel",
            "depName": "stardoc",
            "depType": "bazel_dep",
            "fixedVersion": "0.6.2",
            "packageName": "stardoc",
            "registryUrl": "https://raw.githubusercontent.com/bazelbuild/bazel-central-registry/main",
            "versioning": "bazel-module",
            "warnings": [],
            "updates": []
          }
        ],
        "packageFile": "tests/MODULE.bazel"
      }
    ],
    "github-actions": [
      {
        "deps": [
          {
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # {{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "commitMessageTopic": "{{{depName}}} action",
            "currentValue": "v4",
            "currentVersion": "v4",
            "datasource": "github-tags",
            "depName": "actions/checkout",
            "depType": "action",
            "fixedVersion": "v4",
            "packageName": "actions/checkout",
            "registryUrl": "https://github.com",
            "replaceString": "actions/checkout@v4",
            "sourceUrl": "https://github.com/actions/checkout",
            "versioning": "docker",
            "warnings": [],
            "updates": []
          },
          {
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # {{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "commitMessageTopic": "{{{depName}}} action",
            "currentValue": "v0",
            "currentVersion": "v0",
            "datasource": "github-tags",
            "depName": "tweag/configure-bazel-remote-cache-auth",
            "depType": "action",
            "fixedVersion": "v0",
            "packageName": "tweag/configure-bazel-remote-cache-auth",
            "registryUrl": "https://github.com",
            "replaceString": "tweag/configure-bazel-remote-cache-auth@v0",
            "sourceUrl": "https://github.com/tweag/configure-bazel-remote-cache-auth",
            "versioning": "docker",
            "warnings": [],
            "updates": []
          },
          {
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # {{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "commitMessageTopic": "{{{depName}}} action",
            "currentValue": "v2",
            "currentVersion": "v2",
            "datasource": "github-tags",
            "depName": "extractions/netrc",
            "depType": "action",
            "fixedVersion": "v2",
            "packageName": "extractions/netrc",
            "registryUrl": "https://github.com",
            "replaceString": "extractions/netrc@v2",
            "sourceUrl": "https://github.com/extractions/netrc",
            "versioning": "docker",
            "warnings": [],
            "updates": []
          },
          {
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # {{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "commitMessageTopic": "{{{depName}}} action",
            "currentValue": "v0",
            "currentVersion": "v0",
            "datasource": "github-tags",
            "depName": "tweag/write-bazelrc",
            "depType": "action",
            "fixedVersion": "v0",
            "packageName": "tweag/write-bazelrc",
            "registryUrl": "https://github.com",
            "replaceString": "tweag/write-bazelrc@v0",
            "sourceUrl": "https://github.com/tweag/write-bazelrc",
            "versioning": "docker",
            "warnings": [],
            "updates": []
          },
          {
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # {{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "commitMessageTopic": "{{{depName}}} action",
            "currentValue": "v0",
            "currentVersion": "v0",
            "datasource": "github-tags",
            "depName": "tweag/write-bazelrc",
            "depType": "action",
            "fixedVersion": "v0",
            "packageName": "tweag/write-bazelrc",
            "registryUrl": "https://github.com",
            "replaceString": "tweag/write-bazelrc@v0",
            "sourceUrl": "https://github.com/tweag/write-bazelrc",
            "versioning": "docker",
            "warnings": [],
            "updates": []
          },
          {
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # {{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "commitMessageTopic": "{{{depName}}} action",
            "currentValue": "v0",
            "currentVersion": "v0",
            "datasource": "github-tags",
            "depName": "tweag/write-bazelrc",
            "depType": "action",
            "fixedVersion": "v0",
            "packageName": "tweag/write-bazelrc",
            "registryUrl": "https://github.com",
            "replaceString": "tweag/write-bazelrc@v0",
            "sourceUrl": "https://github.com/tweag/write-bazelrc",
            "versioning": "docker",
            "warnings": [],
            "updates": []
          },
          {
            "autoReplaceStringTemplate": "{{depName}}@{{#if newDigest}}{{newDigest}}{{#if newValue}} # {{newValue}}{{/if}}{{/if}}{{#unless newDigest}}{{newValue}}{{/unless}}",
            "commitMessageTopic": "{{{depName}}} action",
            "currentDigest": "794a2d117251f22607f1aab937d3fd3eaaf9a2f5",
            "currentValue": "v1",
            "currentVersion": "v1",
            "datasource": "github-tags",
            "depName": "cgrindel/gha_join_jobs",
            "depType": "action",
            "fixedVersion": "v1",
            "packageName": "cgrindel/gha_join_jobs",
            "registryUrl": "https://github.com",
            "replaceString": "cgrindel/gha_join_jobs@794a2d117251f22607f1aab937d3fd3eaaf9a2f5 # v1",
            "sourceUrl": "https://github.com/cgrindel/gha_join_jobs",
            "versioning": "docker",
            "warnings": [],
            "updates": []
          },
          {
            "autoReplaceStringTemplate": "{{depName}}-{{newValue}}",
            "currentValue": "latest",
            "datasource": "github-runners",
            "depName": "ubuntu",
            "depType": "github-runner",
            "packageName": "ubuntu",
            "replaceString": "ubuntu-latest",
            "skipReason": "invalid-version",
            "updates": []
          }
        ],
        "packageFile": ".github/workflows/workflow.yaml"
      }
    ]
  }
}

Answered by rarkins

Apr 29, 2024

If Renovate didn't raise a PR then you might never know there's an update.

I recall that the bazel manager has some manual "massaging" of files and URLs for reasons like these. Here's an example I found:

renovate/lib/modules/manager/bazel/artifacts.ts

Lines 34 to 40 in 8749bc7

     const urlMassages = {  
   'bazel-skylib.': 'bazel_skylib-',  
   '/bazel-gazelle/releases/download/0': '/bazel-gazelle/releases/download/v0',  
   '/bazel-gazelle-0': '/bazel-gazelle-v0',  
   '/rules_go/releases/download/0': '/rules_go/releases/download/v0',  
   '/rules_go-0': '/rules_go-v0',  
   };  

 

So you might be able to fix it that way. If not, just manually change the file and after that it…

View full answer

rarkins · 2024-04-25T12:42:05Z

rarkins
Apr 25, 2024
Maintainer

Looking at this:

          {
            "currentValue": "v1.0.1",
            "currentVersion": "v1.0.1",
            "datasource": "github-releases",
            "depName": "rules_sh_shim_exe",
            "depType": "http_file",
            "fixedVersion": "v1.0.1",
            "isSingleVersion": true,
            "managerData": {
              "idx": 0
            },
            "packageName": "ScoopInstaller/Shim",
            "registryUrl": "https://github.com",
            "sourceUrl": "https://github.com/ScoopInstaller/Shim",
            "versioning": "semver-coerced",
            "warnings": [],
            "updates": [
              {
                "bucket": "non-major",
                "newVersion": "v1.1.0",
                "newValue": "v1.1.0",
                "releaseTimestamp": "2024-04-17T07:49:56.000Z",
                "newMajor": 1,
                "newMinor": 1,
                "updateType": "minor",
                "branchName": "renovate/rules_sh_shim_exe-1.x"
              }
            ]
          }
        ],
        "packageFile": "bzlmod/extensions.bzl"
      },

It seems the current SHA isn't detected, which means SHA updating for http_file is not yet supported. It could be a small change to get it working, but I'm not sure. PRs welcome if you feel inclined to look into it yourself. If not, I can convert it into an issue once we have a minimal reproduction we can fork and debug.

3 replies

avdv Apr 25, 2024
Author

I don't think you need to have logic to specifically detect the SHA for http_file in any way. For any URL, you fetch the resource, compute the hash for the old version and the new one. You can replace the old hash everywhere in the repository with the new hash since these hashes tend to be very unique...

avdv Apr 29, 2024
Author

The problem is totally different...

The upstream repository changed the download artifacts, they do not provide the .exe anymore but a zip file instead which contains the exe. Sorry for the noise... 🙈

That just raises the question whether renovate should create a PR when it receives a 404 NOT FOUND response for the URL...

rarkins Apr 29, 2024
Maintainer

If Renovate didn't raise a PR then you might never know there's an update.

I recall that the bazel manager has some manual "massaging" of files and URLs for reasons like these. Here's an example I found:

renovate/lib/modules/manager/bazel/artifacts.ts

Lines 34 to 40 in 8749bc7

    
           const urlMassages = { 
        
             'bazel-skylib.': 'bazel_skylib-', 
        
             '/bazel-gazelle/releases/download/0': '/bazel-gazelle/releases/download/v0', 
        
             '/bazel-gazelle-0': '/bazel-gazelle-v0', 
        
             '/rules_go/releases/download/0': '/rules_go/releases/download/v0', 
        
             '/rules_go-0': '/rules_go-v0', 
        
           };

So you might be able to fix it that way. If not, just manually change the file and after that it hopefully works again.

Answer selected by avdv

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

renovate fails to update sha256 hash for Bazel dependency #28650

{{title}}

Replies: 1 comment 3 replies

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

Select a reply

	const urlMassages = {
	'bazel-skylib.': 'bazel_skylib-',
	'/bazel-gazelle/releases/download/0': '/bazel-gazelle/releases/download/v0',
	'/bazel-gazelle-0': '/bazel-gazelle-v0',
	'/rules_go/releases/download/0': '/rules_go/releases/download/v0',
	'/rules_go-0': '/rules_go-v0',
	};

renovate fails to update sha256 hash for Bazel dependency #28650

avdv Apr 25, 2024

What would you like help with?

How are you running Renovate?

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Please tell us more about your question or problem

Logs (if relevant)

Replies: 1 comment · 3 replies

rarkins Apr 25, 2024 Maintainer

avdv Apr 25, 2024 Author

avdv Apr 29, 2024 Author

rarkins Apr 29, 2024 Maintainer

avdv
Apr 25, 2024

Replies: 1 comment 3 replies

rarkins
Apr 25, 2024
Maintainer

avdv Apr 25, 2024
Author

avdv Apr 29, 2024
Author

rarkins Apr 29, 2024
Maintainer