Add support for reopening autoclosed changes with Gerrit

[felipecrs]

Tell us more.

GitHub relevant code:

renovate/lib/modules/platform/github/index.ts

Lines 943 to 996 in 8ce089b

	const autoclosedPr = await findPr({
	branchName,
	state: 'closed',
	});
	if (
	autoclosedPr?.title?.endsWith(' - autoclosed') &&
	autoclosedPr?.closedAt
	) {
	const closedMillisAgo = DateTime.fromISO(autoclosedPr.closedAt)
	.diffNow()
	.negate()
	.toMillis();
	if (closedMillisAgo > REOPEN_THRESHOLD_MILLIS) {
	return null;
	}
	logger.debug({ autoclosedPr }, 'Found autoclosed PR for branch');
	if (GlobalConfig.get('dryRun')) {
	logger.info('DRY-RUN: Would try to reopen autoclosed PR');
	return null;
	}
	const { sha, number } = autoclosedPr;
	try {
	await ensureBranchSha(branchName, sha!);
	logger.debug(`Recreated autoclosed branch ${branchName} with sha ${sha}`);
	} catch (err) {
	logger.debug(
	{ err, branchName, sha, autoclosedPr },
	'Could not recreate autoclosed branch - skipping reopen',
	);
	return null;
	}
	try {
	const title = autoclosedPr.title.replace(regEx(/ - autoclosed$/), '');
	const { body: ghPr } = await githubApi.patchJson<GhRestPr>(
	`repos/${config.repository}/pulls/${number}`,
	{
	body: {
	state: 'open',
	title,
	},
	},
	);
	logger.info(
	{ branchName, title, number },
	'Successfully reopened autoclosed PR',
	);
	const result = coerceRestPr(ghPr);
	cachePr(result);
	return result;
	} catch (err) {
	logger.debug('Could not reopen autoclosed PR');
	return null;
	}
	}

Gerrit relevant code:

renovate/lib/modules/platform/gerrit/index.ts

Line 220 in 8ce089b

export async function getBranchPr(branchName: string): Promise<Pr | null> {

This more like a reminder for myself, I may work on this.

@NiasSt90 do you see any impediments in this?

[rarkins]

Is this a blocker, or nice to have? e.g. what is the behavior today - do autoclosed changes block the updates, or are updates created in a new branch/PR?

For the referenced github, this was an optimization rather than essential feature.

I can convert this to an issue once there's agreement on the above

[felipecrs]

To be honest with you I have no idea what real improvement this would bring. Certainly, it's not a blocker.

However, Gerrit does have APIs to reopen closed changes, so theoretically this could be implemented.

I was just investigating the code base to try to fix #28774 and noticed this difference between the GitHub provider and Gerrit, so I thought this was a missing feature that should be tracked.

If you believe this has no importance, feel free to close this ticket.

[rarkins]

It's an optimization but definitely not necessary. So you're welcome to submit a PR if you like

[felipecrs]

Sounds good. Thank you.