bug: validator warns to change the last in the schedule field value to first

[Mogyuchi]

What would you like help with?

I think I found a bug

How are you running Renovate?

None

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

renovate validator tells us to change last to first when it validates the below config, which is incorrect.

{
  "schedule": ["on the last day of the month"]
}

$ npx --yes --package renovate@37.354.6 -- renovate-config-validator --strict
 INFO: Validating renovate.json
 WARN: Config migration necessary
       "oldConfig": {"schedule": ["on the last day of the month"]},
       "newConfig": {"schedule": ["on the first day of the month"]}

Logs (if relevant)

No response

[rarkins]

It's an intentional migration, but I don't recall why. Maybe the underlying library we have had a problem with it. When you pick first day, it's always 1. But last day could be 28,29,30,31.

[HonkingGoose]

It's an intentional migration, but I don't recall why.

You created this PR:

• fix: migrate last day of month schedule to first of month #680

To fix issue:

• Renovate not checking day of month in schedule #1047

In that issue you said: ¹

Thank you for reporting the bug. The logs from this repo have helped me find that our existing "is this branch scheduled now?" algorithm ignores day of the month and is only checking day of the week and time of day. So your schedule basically becomes "before 3am". I'll fix!

Footnotes

1. Source for quote ↩

[Mogyuchi]

@rarkins
It should also work on the last day of the month since it has been changed to use the built-in isValid at #9819 .
For information, later uses isValid to test on the last day of the month.
https://github.com/breejs/later/blob/v4.2.0/test/example/text-example-test.js#L339-L363

[rarkins]

You're welcome to submit a PR if you can test that it works as expected