Support MSBuild SDK via Sdk attribute on Project

[ForNeVeR]

Tell us more.

In MSBuild, it's possible to specify the SDK like this:

<Project Sdk="Microsoft.Build.NoTargets/3.4.0">
</Project>

Currently, Renovate supports specifying of these versions via global.json, but not via the project files themselves.

See the documentation (look for the Sdk attribute description).

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

To get started, please read our guide on creating a minimal reproduction.

Good luck,

The Renovate team

[ForNeVeR]

MCVE with a single-file repository: https://github.com/ForNeVeR/msbuild-sdk-usage-example

I expect that Renovate will update Microsoft.Build.NoTargets from version 3.4.0 to 3.7.56.

[rarkins]

Strangely I get this:

DEBUG: Using file match: \.(?:cs|fs|vb)proj$ for manager nuget (repository=ForNeVeR/msbuild-sdk-usage-example)
DEBUG: Using file match: \.(?:props|targets)$ for manager nuget (repository=ForNeVeR/msbuild-sdk-usage-example)
DEBUG: Using file match: (^|/)dotnet-tools\.json$ for manager nuget (repository=ForNeVeR/msbuild-sdk-usage-example)
DEBUG: Using file match: (^|/)global\.json$ for manager nuget (repository=ForNeVeR/msbuild-sdk-usage-example)
...
DEBUG: manager extract durations (ms) (repository=ForNeVeR/msbuild-sdk-usage-example)
       "managers": {}
DEBUG: Found 0 package file(s) (repository=ForNeVeR/msbuild-sdk-usage-example)

I would have expected the nuget manager to attempt to parse this file due to the first file match.

[ForNeVeR]

Oh, I am sorry, my bad. The current nuget analyzer doesn't (and arguably shouldn't) take the .proj files into account automatically: it is only set to specifically consider .csproj, .fsproj, .vbproj (the message has confused me as well while I was setting it up).

I have updated the repo to have a more conventional file extension.

[rarkins]

Yes, that produces the expected log:

DEBUG: Matched 1 file(s) for manager nuget: tdlib.native.csproj (repository=ForNeVeR/msbuild-sdk-usage-example)
DEBUG: manager extract durations (ms) (repository=ForNeVeR/msbuild-sdk-usage-example)
       "managers": {"nuget": 4}
DEBUG: Found 0 package file(s) (repository=ForNeVeR/msbuild-sdk-usage-example)
 INFO: Repository has no package files - skipping (repository=ForNeVeR/msbuild-sdk-usage-example)

I looked in our text fixtures and we don't have any Project sdk= examples with a version embedded which we can reuse.

Converted to a feature request issue: #29101