Node Version

[travi]

I've had the lts_latest policy set in one of my shareable configs for several months. I'd noticed that I hadn't been getting update PRs for node version as a result, but hadn't taken the time to investigate yet.

A couple nights ago, I looked through the renovate logs for one of the projects using that config and confirmed that it was recognizing that there was an update that could be applied. I looked through old config-help threads before opening a new thread and found this one. Adding the suggestion from renovatebot/config-help#667 (comment) to my config did produce PRs to a few of my projects. I got the impression from renovatebot/config-help#667 (comment) that a fix was applied to make it unnecessary since that thread was closed. Did that end up getting applied, or do I have something else wrong with my config that prevents it from working as expected?

I also had a couple of those PRs fail to auto merge, like this one because engines was not updated in the package.json to match the update in the .nvmrc (and I lint to ensure that the current execution environment is within the range defined in engines). Am I wrong in my understanding that this should have been updated to match?

[rarkins]

We disabled major updating for node because Renovate would in some cases otherwise dumbly propose an update from a stable to unstable (e.g. from v14 to v15). I think though now we've merged #7157 we should be able to lift this. The relevant code is here:

renovate/lib/config/definitions.ts

Lines 1560 to 1562 in 326c000

	major: {
	enabled: false,
	},

@viceice wdyt?

[viceice]

We can add a package rule to assign node versioning. Are we doing that already? Then we can enable docker major.

[rarkins]

We need to do two things - grouping all node updates, and assigning versioning. Grouping is currently hardcoded within the core but we should maybe deprecate that in favour of a preset that's included in config:base.

[geraintwhite]

I was seeing the same issue as @travi where I wasn't getting node updates.

Adding node: { major: { enabled: true }} alone didn't fix it for me. I needed to change enabledManagers: ['npm'] to enabledManagers: ['npm', 'nvm'].

After making both those changes I got a merge request updating the node version in .nvmrc, but not package.json > engines.

In the renovate logs I can see node appearing under both npm and nvm.
Under npm it has "major": {"enabled": false} which contradicts what's in the renovate config.

[rarkins]

@grit96 can you reproduce this in a minimal public repo we can take a look at?

[geraintwhite]

https://github.com/grit96/renovate-test

[rarkins]

What's the log for "packageFiles with updates"? Does it detect the dependency but say zero updates available?

[geraintwhite]

DEBUG: packageFiles with updates
{
  "config": {
    "npm": [
      {
        "packageFile": "package.json",
        "deps": [
          {
            "depType": "engines",
            "depName": "node",
            "currentValue": "12",
            "datasource": "github-tags",
            "lookupName": "nodejs/node",
            "versioning": "node",
            "commitMessageTopic": "Node.js",
            "major": {
              "enabled": false
            },
            "prettyDepType": "engine",
            "depIndex": 0,
            "updates": [
              {
                "currentVersion": "v12.20.2",
                "newVersion": "v14.15.5",
                "newValue": "14",
                "bucket": "major",
                "newMajor": 14,
                "newMinor": 15,
                "updateType": "major",
                "isSingleVersion": false,
                "isRange": true,
                "releaseTimestamp": "2021-02-09T16:58:40Z",
                "skippedOverVersions": [
                  "v14.0.0",
                  "v14.1.0",
                  "v14.2.0",
                  "v14.3.0",
                  "v14.4.0",
                  "v14.5.0",
                  "v14.6.0",
                  "v14.7.0",
                  "v14.8.0",
                  "v14.9.0",
                  "v14.10.0",
                  "v14.10.1",
                  "v14.11.0",
                  "v14.12.0",
                  "v14.13.0",
                  "v14.13.1",
                  "v14.14.0",
                  "v14.15.0",
                  "v14.15.1",
                  "v14.15.2",
                  "v14.15.3",
                  "v14.15.4"
                ]
              }
            ],
            "warnings": [],
            "sourceUrl": "https://github.com/nodejs/node"
          },
          {
            "depType": "engines",
            "depName": "npm",
            "currentValue": "6",
            "datasource": "npm",
            "commitMessageTopic": "npm",
            "prettyDepType": "engine",
            "depIndex": 1,
            "updates": [
              {
                "currentVersion": "6.14.11",
                "newVersion": "7.5.4",
                "newValue": "7",
                "bucket": "major",
                "newMajor": 7,
                "newMinor": 5,
                "updateType": "major",
                "isSingleVersion": false,
                "isRange": true,
                "releaseTimestamp": "2021-02-12T18:13:53.144Z",
                "skippedOverVersions": [
                  "7.0.0",
                  "7.0.1",
                  "7.0.2",
                  "7.0.3",
                  "7.0.4",
                  "7.0.5",
                  "7.0.6",
                  "7.0.7",
                  "7.0.8",
                  "7.0.9",
                  "7.0.10",
                  "7.0.11",
                  "7.0.12",
                  "7.0.13",
                  "7.0.14",
                  "7.0.15",
                  "7.1.0",
                  "7.1.1",
                  "7.1.2",
                  "7.2.0",
                  "7.3.0",
                  "7.4.0",
                  "7.4.1",
                  "7.4.2",
                  "7.4.3",
                  "7.5.0",
                  "7.5.1",
                  "7.5.2",
                  "7.5.3"
                ]
              }
            ],
            "warnings": [],
            "sourceUrl": "https://github.com/npm/cli",
            "homepage": "https://docs.npmjs.com/"
          }
        ],
        "packageJsonName": "renovate-test",
        "packageFileVersion": "1.0.0",
        "packageJsonType": "library",
        "skipInstalls": true,
        "constraints": {
          "node": "12",
          "npm": "6"
        }
      }
    ],
    "nvm": [
      {
        "packageFile": ".nvmrc",
        "deps": [
          {
            "depName": "node",
            "currentValue": "12",
            "datasource": "github-tags",
            "lookupName": "nodejs/node",
            "depIndex": 0,
            "updates": [
              {
                "currentVersion": "v12.20.2",
                "newVersion": "v14.15.5",
                "newValue": "14",
                "bucket": "major",
                "newMajor": 14,
                "newMinor": 15,
                "updateType": "major",
                "isSingleVersion": false,
                "isRange": true,
                "releaseTimestamp": "2021-02-09T16:58:40Z",
                "skippedOverVersions": [
                  "v14.0.0",
                  "v14.1.0",
                  "v14.2.0",
                  "v14.3.0",
                  "v14.4.0",
                  "v14.5.0",
                  "v14.6.0",
                  "v14.7.0",
                  "v14.8.0",
                  "v14.9.0",
                  "v14.10.0",
                  "v14.10.1",
                  "v14.11.0",
                  "v14.12.0",
                  "v14.13.0",
                  "v14.13.1",
                  "v14.14.0",
                  "v14.15.0",
                  "v14.15.1",
                  "v14.15.2",
                  "v14.15.3",
                  "v14.15.4"
                ]
              }
            ],
            "warnings": [],
            "sourceUrl": "https://github.com/nodejs/node"
          }
        ]
      }
    ]
  }
}