How to assign a PR to one or more persons

[ronaldploeger]

Hi,

I have set up renovate with Bitbucket server and it is creating PRs for me now. But it does not assign anybody to the PRs.

I have tried to specify the "assignees" and the "reviewers" configuration option in renovate.json to no avail:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": ["config:base"],
  "assignees": ["rploeger"],
  "reviewers": ["rploeger"],
  "branchPrefix": "feature-renovate-"
}

I have tried the username and also the email address.

How is this correctly configured for Bitbucket Server?

Thanks,
Ronald

[viceice]

Please check the debug logs. run renovate with LOG_LEVEL=debug, this should show you the problem.

[nickstolwijk]

I have the same problem with BitBucket server and ran it with debug:
With mailaddress:

DEBUG: Ensuring PR (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
DEBUG: There are 0 errors and 0 warnings (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
DEBUG: getBranchPr(renovate/nl.company.sde-company-java-testtools-bom-1.x) (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
DEBUG: findPr(renovate/nl.company.sde-company-java-testtools-bom-1.x, "undefined", "open") (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
DEBUG: getPrList() (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
DEBUG: returning cached PR list (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
DEBUG: DID NOT Found PR from branch #renovate/nl.company.sde-company-java-testtools-bom-1.x (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
DEBUG: getPrBody(This PR contains the following updates:) (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
DEBUG: Creating PR (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
       "prTitle": "Update dependency nl.company.sde:company-java-testtools-bom to v1.10.1"
DEBUG: createPr(renovate/nl.company.sde-company-java-testtools-bom-1.x, title=Update dependency nl.company.sde:company-java-testtools-bom to v1.10.1) (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
DEBUG: fetching default reviewers (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
 INFO: PR created (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
       "pr": 1,
       "prTitle": "Update dependency nl.company.sde:company-java-testtools-bom to v1.10.1"
DEBUG: addAssignees(1, [nick.stolwijk@company.nl]) (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
DEBUG: Added assignees (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
       "assignees": ["nick.stolwijk@company.nl"]
DEBUG: Created Pull Request #1 (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
DEBUG: Checking #1 for automerge (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)
       "automerge": false,
       "automergeType": "pr",
       "automergeComment": "automergeComment"
DEBUG: No automerge (repository=bib/example_project, branch=renovate/nl.company.sde-company-java-testtools-bom-1.x)

And with username:

DEBUG: Ensuring PR (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
DEBUG: There are 0 errors and 0 warnings (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
DEBUG: getBranchPr(renovate/jakarta.mail-jakarta.mail-api-2.x) (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
DEBUG: findPr(renovate/jakarta.mail-jakarta.mail-api-2.x, "undefined", "open") (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
DEBUG: getPrList() (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
DEBUG: returning cached PR list (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
DEBUG: DID NOT Found PR from branch #renovate/jakarta.mail-jakarta.mail-api-2.x (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
DEBUG: getPrBody(This PR contains the following updates:) (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
DEBUG: Creating PR (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
       "prTitle": "Update dependency jakarta.mail:jakarta.mail-api to v2"
DEBUG: createPr(renovate/jakarta.mail-jakarta.mail-api-2.x, title=Update dependency jakarta.mail:jakarta.mail-api to v2) (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
DEBUG: fetching default reviewers (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
 INFO: PR created (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
       "pr": 12,
       "prTitle": "Update dependency jakarta.mail:jakarta.mail-api to v2"
DEBUG: addAssignees(12, [stolwn1]) (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
DEBUG: Added assignees (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
       "assignees": ["stolwn1"]
DEBUG: Created Pull Request #12 (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
DEBUG: Checking #12 for automerge (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)
       "automerge": false,
       "automergeType": "pr",
       "automergeComment": "automergeComment"
DEBUG: No automerge (repository=bib/example_project, branch=renovate/jakarta.mail-jakarta.mail-api-2.x)

Both tries it didn't show up in Bitbucket. :-(

[nickstolwijk]

I guess I have found the issue:

export function addAssignees(iid: number, assignees: string[]): Promise<void> {
  logger.debug(`addAssignees(${iid}, [${assignees.join(', ')}])`);
  // TODO: Needs implementation
  // Currently Renovate does "Create PR" and then "Add assignee" as a two-step process, with this being the second step.
  // BB Server doesnt support assignees
  return Promise.resolve();
}

I will try it with reviewers. :-D

[nickstolwijk]

I tried it with reviewers and my username and that worked. I did throw away the existing PR and branch before retrying, because I read that Renovate will not add a reviewer again in case someone unsubscribes themself.

[ronaldploeger]

Got it working with "reviewers" and username - BUT as soon as there is one username in the array which does not exist in bitbucket - no one is added as a reviewer.

With logging set to debug there is a message in this case - which I guess should be a warning:

DEBUG: Failed to add reviewers ....
...
             "errors": [
               {
                 "context": "reviewers",
                 "message": "Errors encountered while adding some reviewers to this pull request.",
                 "exceptionName": "com.atlassian.bitbucket.pull.InvalidPullRequestReviewersException",
                 "reviewerErrors": [
                   {
                     "context": "myUsername",
                     "message": "myUsername is not a user.",
                     "exceptionName": null
                   }
                 ],

Bonus question: What is the difference between "assignees" and "reviewers"?

[rarkins]

The difference between assignees and reviewers is platform-dependent. When they are separate, the assignee(s) is typically who's responsible for deciding to merge and moving it forward, while reviewers are people who have some expertise related to the PR and are requested to take a look

[ronaldploeger]

Thank you @rarkins