PR hourly limit remaining: 0

[janpio]

For some reason a new repo where we are using the Renovate CLI gets this in the Dependency Dashboard issues:

Rate Limited
These updates are currently rate limited. Click on a checkbox below to force their creation now.

In the logs I can find this:

...
DEBUG: Fetching changelog: renovatebot/renovate (24.49.9 -> 24.52.0) (repository=prisma/prisma-version-monitor)
DEBUG: config.repoIsOnboarded=true (repository=prisma/prisma-version-monitor)
DEBUG: processRepo() (repository=prisma/prisma-version-monitor)
DEBUG: Processing 3 branches: renovate/integration-renovate-24.x, renovate/latest-prisma-monorepo, renovate/patch-dev-renovate-24.x (repository=prisma/prisma-version-monitor)
DEBUG: Calculating hourly PRs remaining (repository=prisma/prisma-version-monitor)
DEBUG: Retrieving PR list (repository=prisma/prisma-version-monitor)
DEBUG: Retrieved 3 Pull Requests (repository=prisma/prisma-version-monitor)
DEBUG: currentHourStart=2021-02-16T15:00:00.000+00:00 (repository=prisma/prisma-version-monitor)
DEBUG: PR hourly limit remaining: 0 (repository=prisma/prisma-version-monitor)
DEBUG: Calculating prConcurrentLimit (20) (repository=prisma/prisma-version-monitor)
...

How does it come to the conclusion of PR hourly limit remaining: 0?

Our configuration does not use prHourlyLimit at all, so I would expect it to create as many PRs as possible.

From reading the code, I think it should return 99 here and use that to do the calculation:

renovate/lib/workers/repository/process/limits.ts

Lines 10 to 41 in 44004bf

	export async function getPrHourlyRemaining(
	config: RenovateConfig
	): Promise<number> {
	if (config.prHourlyLimit) {
	try {
	logger.debug('Calculating hourly PRs remaining');
	const prList = await platform.getPrList();
	const currentHourStart = DateTime.local().startOf('hour');
	logger.debug(`currentHourStart=${String(currentHourStart)}`);
	const soFarThisHour = prList.filter(
	(pr) =>
	pr.sourceBranch !== config.onboardingBranch &&
	pr.sourceBranch.startsWith(config.branchPrefix) &&
	DateTime.fromISO(pr.createdAt) > currentHourStart
	);
	const prsRemaining = Math.max(
	0,
	config.prHourlyLimit - soFarThisHour.length
	);
	logger.debug(`PR hourly limit remaining: ${prsRemaining}`);
	return prsRemaining;
	} catch (err) {
	// istanbul ignore if
	if (err instanceof ExternalHostError) {
	throw err;
	}
	logger.error({ err }, 'Error checking PRs created per hour');
	return config.prHourlyLimit;
	}
	}
	return 99;
	}

[rarkins]

If you extend config:base then it is configured to create 2 PRs per hour maximum, excluding the onboarding PR. And if so then that would also have been described in the onboarding PR description when it was first created.

[janpio]

Interesting. Seems we did not get any onboarding PR for that repo even - as we started with a renovate.json file maybe?

I opened a PR to surface the actual value: #8720