Using allowedVersions within a PackageRules Group

[tobybellwood]

I've got a PackageRule group set up to group updates for the ELK stack. Given the licence woes, I'd like it to not recommend upgrades to non-suitable licences - so have added an allowedVersions field - however this is not being respected, and I'm getting 7.11.1 recommended as an update from 7.6.1 (tobybellwood/lagoon-images#3) - am I doing this wrong?

{
  "groupName": "ELK Stack",
  "allowedVersions": "<7.11.0",
  "matchDatasources": [
    "docker"
  ],
  "matchUpdateTypes": [
    "patch",
    "minor"
  ],
  "matchPackageNames": [
    "docker.elastic.co/elasticsearch/elasticsearch",
    "docker.elastic.co/logstash/logstash",
    "docker.elastic.co/kibana/kibana"
  ]
},

[viceice]

Can you please check and paste the debug logs

[tobybellwood]

here's the resolver snippet for elasticsearch

          {
            "depName": "docker.elastic.co/elasticsearch/elasticsearch",
            "currentValue": "7.6.1",
            "replaceString": "docker.elastic.co/elasticsearch/elasticsearch:7.6.1",
            "autoReplaceStringTemplate": "{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}",
            "datasource": "docker",
            "depType": "final",
            "depIndex": 1,
            "updates": [
              {
                "currentVersion": "7.6.1",
                "newVersion": "7.6.2",
                "newValue": "7.6.2",
                "bucket": "patch",
                "newMajor": 7,
                "newMinor": 6,
                "updateType": "patch",
                "isSingleVersion": true
              },
              {
                "currentVersion": "7.6.1",
                "newVersion": "7.11.1",
                "newValue": "7.11.1",
                "bucket": "minor",
                "newMajor": 7,
                "newMinor": 11,
                "updateType": "minor",
                "isSingleVersion": true,
                "skippedOverVersions": [
                  "7.7.0",
                  "7.7.1",
                  "7.8.0",
                  "7.8.1",
                  "7.9.0",
                  "7.9.1",
                  "7.9.2",
                  "7.9.3",
                  "7.10.0",
                  "7.10.1",
                  "7.10.2",
                  "7.11.0"
                ]
              }
            ],
            "warnings": [],
            "fixedVersion": "7.6.1",
            "sourceUrl": "https://github.com/elastic/elasticsearch",
            "dockerRegistry": "https://docker.elastic.co",
            "dockerRepository": "elasticsearch/elasticsearch"
          }
        ]
      },

The full job is at https://app.renovatebot.com/dashboard#github/tobybellwood/lagoon-images/303999205

DEBUG: branchifyUpgrades
DEBUG: Using group branchName template
DEBUG: Dependency docker.elastic.co/elasticsearch/elasticsearch is part of group ELK Stack
DEBUG: Using group branchName template
DEBUG: Dependency docker.elastic.co/elasticsearch/elasticsearch is part of group ELK Stack
DEBUG: Using group branchName template
DEBUG: Dependency docker.elastic.co/elasticsearch/elasticsearch is part of group ELK Stack
DEBUG: Using group branchName template
DEBUG: Dependency docker.elastic.co/kibana/kibana is part of group ELK Stack
DEBUG: Using group branchName template
DEBUG: Dependency docker.elastic.co/kibana/kibana is part of group ELK Stack
DEBUG: Using group branchName template
DEBUG: Dependency docker.elastic.co/kibana/kibana is part of group ELK Stack
DEBUG: Using group branchName template
DEBUG: Dependency docker.elastic.co/logstash/logstash is part of group ELK Stack
DEBUG: Using group branchName template
DEBUG: Dependency docker.elastic.co/logstash/logstash is part of group ELK Stack
DEBUG: Using group branchName template
DEBUG: Dependency docker.elastic.co/logstash/logstash is part of group ELK Stack
DEBUG: 10 flattened updates found: docker.elastic.co/elasticsearch/elasticsearch, docker.elastic.co/elasticsearch/elasticsearch, docker.elastic.co/elasticsearch/elasticsearch, docker.elastic.co/kibana/kibana, docker.elastic.co/kibana/kibana, docker.elastic.co/kibana/kibana, docker.elastic.co/logstash/logstash, docker.elastic.co/logstash/logstash, docker.elastic.co/logstash/logstash, python
DEBUG: Returning 3 branch(es)
DEBUG: Fetching changelog: https://github.com/elastic/kibana (7.6.1 -> 7.6.2)
DEBUG: Fetching changelog: https://github.com/elastic/kibana (6.8.2 -> 6.8.14)
DEBUG: Fetching changelog: https://github.com/elastic/elasticsearch (7.6.1 -> 7.6.2)
DEBUG: Fetching changelog: https://github.com/elastic/elasticsearch (6.8.2 -> 6.8.14)
DEBUG: Fetching changelog: https://github.com/elastic/kibana (7.6.1 -> 7.11.1)
DEBUG: Fetching changelog: https://github.com/elastic/elasticsearch (7.6.1 -> 7.11.1)

[rarkins]

Filtering of allowedVersions is done before we know the updateTypes, so this rule gets applied too late. I think if you remove the updateTypes field it should work.

[tobybellwood]

Damn - you're a wizard!

That's perfect - it worked just as expected!!

Package	Type	Update	Change
docker.elastic.co/elasticsearch/elasticsearch	final	minor	7.6.1 -> 7.10.2
docker.elastic.co/kibana/kibana	final	minor	7.6.1 -> 7.10.2
docker.elastic.co/logstash/logstash	final	minor	7.3.0 -> 7.10.2

I've got a separate rule set to exclude the major updates anyway, so having the updateTypes set here was superfluous anyway

    {
      "enabled": false,
      "matchDatasources": [
        "docker"
      ],
      "matchUpdateTypes": [
        "major"
      ],
      "matchPackageNames": [
        "docker.elastic.co/elasticsearch/elasticsearch",
        "docker.elastic.co/logstash/logstash",
        "docker.elastic.co/kibana/kibana"
      ]
    },
    ```

[rarkins]

Combining updateTypes filtering with other fields is one of the more common errors. I'm considering:

• Catching it as a config error
• Any ways we have to get it to still work (e.g. massage it into two rules if possible)
• Just accept that any complex querying system can have the ability to define rules which are never true (e.g. like in SQL)