New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): migrate requiredStatusChecks to ignoreTests #11355
Conversation
06d3578
to
395bd46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@viceice @JamieMagee can you review if you think the migration class is the right approach going forward?
I think it's a nice idea (I say as I'm currently migrating datasources to be classes 😅). I think it'll make them easier to write and test, as we can enforce things from the abstract |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See other comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some new suggestions, so the ignoreTests
can be completly removed from platform.getBranchStatus
code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my suggestions
01f7b2a
to
ad385e7
Compare
@viceice Everything is done |
Please use the re-request review button. 😉 |
@JamieMagee Any comments about the migration code? Any idea for optimizations / improvements here? |
@rarkins @JamieMagee can we merge this branch? Do you expect any changes/comments from my side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs deconflicting / snapshot updates
Deconflicted |
LGTM 👍 Will wait and give @viceice a chance to review. |
🎉 This PR is included in version 27.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Migration
. Now any new migration should extend itrequiredStatusChecks
toignoreTests
Context:
Fixes #11163
Documentation
How I've tested my work
I have verified these changes via: