feat(gradle-wrapper): add support for multiple version occurrences in distributionUrl #11454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndzeitBegins
changed the title
…radle/deep move interface GradleVersionExtract to types.ts remove unused test snapshots
viceice
requested changes
Aug 28, 2021
lib/manager/gradle-wrapper/__fixtures__/gradle-wrapper-all.properties
Outdated
Show resolved
Hide resolved
lib/manager/gradle-wrapper/__fixtures__/gradle-wrapper-whitespace.properties
Outdated
Show resolved
Hide resolved
HonkingGoose
suggested changes
Aug 29, 2021
simplify some sentence structures Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
viceice
reviewed
Aug 29, 2021
viceice
approved these changes
Aug 29, 2021
|
🎉 This PR is included in version 26.13.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Thanks for the initial feedback, fast review and merge. 👍🏻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The version of Gradle Wrapper is updated at every appearance inside the
distributionUrlinside the
gradle/wrapper/gradle-wrapper.propertiesinstead of just in the file name.Context:
Closes #11431
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: