Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor migrations #11457

Closed
Tracked by #16359
pret-a-porter opened this issue Aug 27, 2021 · 2 comments
Closed
Tracked by #16359

Refactor migrations #11457

pret-a-porter opened this issue Aug 27, 2021 · 2 comments
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:blocked Issue is blocked by another issue or external requirement type:refactor Refactoring or improving of existing code

Comments

@pret-a-porter
Copy link
Contributor

Describe the proposed change(s).

After merge PR #11355 I would like to:

  1. Refactor all migrations by new approach, therefore each migration will be in separate class
  2. Refactor migrations unit tests, therefore each migration unit test will be in separate file as well

It will increase maintainability of migrations greatly
@pret-a-porter pret-a-porter added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:refactor Refactoring or improving of existing code labels Aug 27, 2021
@rarkins rarkins added priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:ready status:blocked Issue is blocked by another issue or external requirement and removed status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Aug 28, 2021
@rarkins
Copy link
Collaborator

rarkins commented Aug 28, 2021

Blocked by #11459. I don't want to invest time in refactoring migrations until we have that feature worked out.

@pret-a-porter
Copy link
Contributor Author

#9611 can be done as part of this refactoring

@pret-a-porter pret-a-porter mentioned this issue Nov 16, 2021
Merged
6 tasks
@HonkingGoose HonkingGoose mentioned this issue Jul 2, 2022
Open
23 tasks
@rarkins rarkins closed this as completed Jul 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:blocked Issue is blocked by another issue or external requirement type:refactor Refactoring or improving of existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rarkins @pret-a-porter