Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gradle): support @<ext> file extentions #11541

Merged
merged 6 commits into from Sep 6, 2021
Merged

feat(gradle): support @<ext> file extentions #11541

merged 6 commits into from Sep 6, 2021

Conversation

t-kulmburg
Copy link
Contributor

Changes:

Before this change, gradle extentions, where the file type is defined behind the version, were not recognized. This PR adds this functionality, but the file extention is not really used to search the dependency.
Dependencies with such a qualifier look like this: foo.bar:baz:1.2.3@ext

Context:

Issue 11324

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Sep 2, 2021

CLA assistant check
All committers have signed the CLA.

@viceice viceice changed the title gradle @<ext> file extentions feat(gradle): support @<ext> file extentions Sep 2, 2021
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign CLA, see CLA comment

@t-kulmburg
Copy link
Contributor Author

I just signed the CLA

@rarkins rarkins requested a review from viceice September 6, 2021 13:22
Copy link
Collaborator

@zharinov zharinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@viceice viceice enabled auto-merge (squash) September 6, 2021 17:42
@viceice viceice merged commit 773a111 into renovatebot:main Sep 6, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 26.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants