Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/helmv3): support helm chart dependencies in OCI images #11584

Merged
merged 2 commits into from Sep 6, 2021

Conversation

secustor
Copy link
Collaborator

@secustor secustor commented Sep 5, 2021

Changes:

Add support for parsing references using the oci:// protocol

Context:

Closes #11568

I didn't managed to get lockfile maintenance working. Not sure this is because I use podman or because I had to use other images as the image references provided by @ankitabhopatkar13 are not public

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

https://github.com/secustor/renovate-helm-oci

@rarkins rarkins enabled auto-merge (squash) September 6, 2021 09:17
@rarkins rarkins merged commit 27861b7 into renovatebot:main Sep 6, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 26.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@secustor secustor deleted the support_oci_helm_charts branch September 6, 2021 09:49
@ankitabhopatkar13
Copy link
Contributor

@secustor Really happy with such a fast response, thanks a lot!

I was trying to use this version of renovate-runner(3.17.0) on gitlab-ci. My helm charts are hosted in a private Gitlab Container Registry which is basically OCI based.

I was wondering if I can use the helm charts hosted in private Gitlab Container Registry. I saw the documentation here, tried to use the hostRules but I still get the following error -

{
                     "topic": "dependency-name",
                     "message": "Failed to look up dependency dependency-name"
                   }

I am trying to authenticate with Gitlab deploy token and the configuration looks like below -

  hostRules: [
    {
      hostType: 'docker',
      matchHost: process.env.CI_REGISTRY,
      username: 'ci-deploy-token',
      password: process.env.GITLAB_CI_CHARTS_DEPLOY_TOKEN,
    },

I also tried with token, but same error.

Thanks in Advance!

@secustor
Copy link
Collaborator Author

secustor commented Sep 6, 2021

You're welcome, but please open a discussion for this to keep the PR clean. Further this enables other users with the same issue to find it later on.

There you can ping again. I will look into it when I have time.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCI support for helm dependencies
4 participants