Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/gradle): ignore catalog deps without version #11621

Merged
merged 4 commits into from Sep 7, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented Sep 7, 2021

Changes:

Ignore dependencies without a version.

Context:

fixes #11619

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice changed the title fix(manager/gradle): support catalog modules without version fix(manager/gradle): ignore catalog deps without version Sep 7, 2021
@viceice viceice marked this pull request as ready for review September 7, 2021 12:10
@rarkins rarkins mentioned this pull request Sep 7, 2021
Copy link
Collaborator

@zharinov zharinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if all possible parsing warnings are really mitigated now. Or maybe, leave try-catch block for now?

@viceice
Copy link
Member Author

viceice commented Sep 7, 2021

I think it's safe now. Don't like the double catch block.

@viceice viceice merged commit 87d2647 into main Sep 7, 2021
@viceice viceice deleted the fix/gradle-catalogs branch September 7, 2021 17:51
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 26.21.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOML parsing error
4 participants