Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): better github bot massage during validation #11622

Merged
merged 2 commits into from Sep 7, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Sep 7, 2021

Changes:

Fixes gitAuthor parsing for GitHub bots

Context:

GitHub bot email addresses are technically invalid so we need to work around. Our old workaround wasn't good enough.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins merged commit 1150b8d into main Sep 7, 2021
@rarkins rarkins deleted the fix/git-author-validation branch September 7, 2021 12:28
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 26.21.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants