Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken link to image #11638

Merged
merged 3 commits into from Sep 8, 2021
Merged

Conversation

HonkingGoose
Copy link
Collaborator

@HonkingGoose HonkingGoose commented Sep 8, 2021

Changes:

  • Try to fix broken link to image

Context:

I did not see that the picture was broken after PR #11490 until now...

It works on the GitHub preview, not sure if this will work on the published site. Please check my work. 馃槈

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@HonkingGoose
Copy link
Collaborator Author

HonkingGoose commented Sep 8, 2021

Would we be better off having something like this instead?

<figure>
  <img src="INSERT LINK TO IMAGE HERE" />
  <figcaption>Image of PR being automerged</figcaption>
</figure>

@rarkins
Copy link
Collaborator

rarkins commented Sep 8, 2021

We can try and learn.. whether it's best to use absolute URLs or relative

@rarkins rarkins merged commit 357068d into renovatebot:main Sep 8, 2021
@HonkingGoose HonkingGoose deleted the patch-2 branch September 8, 2021 08:41
@renovate-release
Copy link
Collaborator

馃帀 This PR is included in version 26.21.7 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants