Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cancel outdated codeql jobs #11656

Merged
merged 3 commits into from Sep 9, 2021
Merged

ci: cancel outdated codeql jobs #11656

merged 3 commits into from Sep 9, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented Sep 9, 2021

Changes:

Otherwise they will run until finished and consume a lot ci resources

works here: https://github.com/renovatebot/internal-tools/blob/main/.github/workflows/codeql-analysis.yml

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins September 9, 2021 14:11
@viceice viceice enabled auto-merge (squash) September 9, 2021 14:17
@HonkingGoose
Copy link
Collaborator

@rarkins @viceice There's a typo in the PR title. 😉

cancle -> cancel

Hmm GitHub has removed my ability to disable the auto-merge, used to be I could cancel it with triage level rights.

@rarkins rarkins changed the title ci: cancle outdated codeql jobs ci: cancel outdated codeql jobs Sep 9, 2021
@viceice viceice merged commit bfed45a into main Sep 9, 2021
@viceice viceice deleted the viceice-patch-1 branch September 9, 2021 19:14
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 27.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose
Copy link
Collaborator

The release notes still have the bad spelling in them, but the PR title was changed prior to the merge. It should have squashed the message to the correct spelling...

Commit that still has the bad spelling: https://github.com/renovatebot/renovate/tree/bfed45a5cc1fadb5a1a9168f7c9a7c03067b54d5

Release notes with bad spelling: https://github.com/renovatebot/renovate/releases/tag/27.3.3

Not sure what's going wrong here, as far as I understand, semantic-release should have picked up the correct PR title when doing the squash merge?

@viceice
Copy link
Member Author

viceice commented Sep 12, 2021

I think GitHub is using the commit message as merge title when there is only one commit. You also don't see the real merge title on smartphone app by default. 😕

@HonkingGoose
Copy link
Collaborator

I think GitHub is using the commit message as merge title when there is only one commit.

But we have 3 commits, at least according to the GitHub UI timeline:

  1. Your commit with the change
  2. Your commit merging main into viceice-patch-1
  3. rarkins commit merging main into viceice-patch-1

Maybe those commits syncing main don't count when doing a squash-merge.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants