Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource): add Gitlab Package support #11672

Merged
merged 48 commits into from Sep 16, 2021

Conversation

samdolt
Copy link
Contributor

@samdolt samdolt commented Sep 10, 2021

Changes:

Add a new Gitlab Package datasource

Context:

See #10892 for more background

Gitlab Package API is documented here: https://docs.gitlab.com/ee/api/packages.html

This code was made by coping the gitlab-tags datasource, as it's doing basically the same thing, but calling another api endpoints.

It's my first time using Typescript, so surely the code could be improved

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

Documentation would be added after the first code review

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

The code was used to create this merge request: https://gitlab.com/samdolt1/renovate-test-1/-/merge_requests/4
Unit tests are in progress

samdolt and others added 30 commits September 10, 2021 10:50
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
samdolt and others added 2 commits September 10, 2021 10:50
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@samdolt samdolt changed the title Feat/gitlab packages feat(datasource): add Gitlab Package support Sep 10, 2021
@viceice
Copy link
Member

viceice commented Sep 10, 2021

Please copy the pr description to this pr

@samdolt samdolt marked this pull request as ready for review September 10, 2021 13:20
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

lib/datasource/gitlab-packages/index.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly good to go. Just a few things to change/review.

lib/datasource/gitlab-packages/readme.md Outdated Show resolved Hide resolved
lib/datasource/gitlab-packages/readme.md Outdated Show resolved Hide resolved
lib/datasource/gitlab-packages/readme.md Show resolved Hide resolved
lib/datasource/gitlab-packages/index.ts Outdated Show resolved Hide resolved
lib/datasource/gitlab-packages/index.ts Outdated Show resolved Hide resolved
samdolt and others added 7 commits September 15, 2021 10:45
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
lib/util/http/host-rules.spec.ts Outdated Show resolved Hide resolved
lib/util/http/host-rules.spec.ts Outdated Show resolved Hide resolved
@viceice viceice enabled auto-merge (squash) September 16, 2021 10:40
@viceice viceice merged commit d676ce5 into renovatebot:main Sep 16, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 27.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants