Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check git version #11687

Merged
merged 43 commits into from Sep 15, 2021
Merged

test: check git version #11687

merged 43 commits into from Sep 15, 2021

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Sep 11, 2021

Changes:

Added an esm js file to check git version for compatibility. If found not compatible it will prevent unit testing.

Context:

PR created to solve the issue #11167 during tests only

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

I wanted to ask how workflow testing works, cause when I run the workflow then the tests on different OS run, and then lint runs separately, so how is the checking on all three OS happening, I do not get that.

.vscode/settings.json Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
tools/check-git-version.js Outdated Show resolved Hide resolved
tools/check-git-version.js Outdated Show resolved Hide resolved
tools/check-git-version.js Outdated Show resolved Hide resolved
tools/check-git-version.js Outdated Show resolved Hide resolved
@RahulGautamSingh RahulGautamSingh changed the title Feat/check git version feat:check git version Sep 11, 2021
Co-authored-by: Rhys Arkins <rhys@arkins.net>
tools/check-git-version.js Outdated Show resolved Hide resolved
@HonkingGoose
Copy link
Collaborator

Hi @RahulGautamSingh, I see you're hard at work on your first PR! 😄 ❤️

Did you know that you can close a issue automatically with your PR?

Quote from GitHub docs:

To link a pull request to an issue to show that a fix is in progress and to automatically close the issue when someone merges the pull request, type one of the following keywords followed by a reference to the issue. For example, Closes #10 or Fixes octo-org/octo-repo#100.

Read the GitHub docs, using keywords in issues and pull requests to learn more, and to see the full list of valid keywords.


Also the PR title needs a small fix, you need to put a space between feat: and check git version for it to pass the "Semantic Pull Request" status check.

@RahulGautamSingh RahulGautamSingh changed the title feat:check git version feat: check git version Sep 13, 2021
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review September 13, 2021 07:40
.github/workflows/build.yml Outdated Show resolved Hide resolved
.vscode/extensions.json Outdated Show resolved Hide resolved
.vscode/launch.json Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
tools/check-git-version.js Outdated Show resolved Hide resolved
tools/check-git-version.js Outdated Show resolved Hide resolved
tools/check-git-version.js Outdated Show resolved Hide resolved
tools/check-git-version.js Outdated Show resolved Hide resolved
tools/check-git-version.js Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
RahulGautamSingh and others added 5 commits September 13, 2021 13:59
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins rarkins changed the title feat: check git version test: check git version Sep 15, 2021
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
tools/check-git-version.mjs Outdated Show resolved Hide resolved
tools/check-git-version.mjs Show resolved Hide resolved
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
viceice previously approved these changes Sep 15, 2021
@viceice viceice enabled auto-merge (squash) September 15, 2021 13:33
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs prettier-fix run 🙃

@RahulGautamSingh
Copy link
Collaborator Author

This needs to be tested against Windows and Mac VMs before we merge

needs prettier-fix run 🙃

I will pull it and commit again now.

auto-merge was automatically disabled September 15, 2021 14:28

Head branch was pushed to by a user without write access

.vscode/settings.json Outdated Show resolved Hide resolved
@rarkins rarkins marked this pull request as draft September 15, 2021 14:32
@RahulGautamSingh
Copy link
Collaborator Author

Should I make it ready for review now,

@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review September 15, 2021 14:49
@viceice viceice enabled auto-merge (squash) September 15, 2021 14:58
@viceice viceice merged commit 1d528fc into renovatebot:main Sep 15, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 27.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@RahulGautamSingh RahulGautamSingh deleted the feat/check-git-version branch September 17, 2021 09:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants