Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badly spelled words in code versionings #11694

Closed
HonkingGoose opened this issue Sep 12, 2021 · 6 comments
Closed

Badly spelled words in code versionings #11694

HonkingGoose opened this issue Sep 12, 2021 · 6 comments
Assignees
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:requirements Full requirements are not yet known, so implementation should not be started type:refactor Refactoring or improving of existing code

Comments

@HonkingGoose
Copy link
Collaborator

Describe the proposed change(s).

We use versionings and versionig in our code in some places, both of which are spelled wrong... 馃檲

I found them by doing a search for both these strings in our *.ts files. But we might have more instances lurking somewhere.

versionings is not a proper English word, or at least my spell checker doesn't think so.

I think we have two options:

  1. Use singular noun: versioning
  2. Use plural noun: versions

I originally found this problem in PR: #11429 (comment)

I already opened a PR to fix the versionig in a spec file: #11693, so that's one of the bad spellings gone.
But we still need to decide what to do with versionings... 馃槈

@HonkingGoose HonkingGoose added type:refactor Refactoring or improving of existing code status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Sep 12, 2021
@HonkingGoose HonkingGoose added priority-4-low Low priority, unlikely to be done unless it becomes important to more people and removed priority-5-triage labels Sep 12, 2021
@RahulGautamSingh
Copy link
Collaborator

I found versionings in these 3 files:

  1. /workspaces/renovate/lib/versioning/index.spec.ts
  2. /workspaces/renovate/lib/versioning/versioning-metadata.spec.ts
  3. /workspaces/renovate/lib/workers/repository/init/vulnerability.ts
    Do you want them changed or let them be for now?

@rarkins
Copy link
Collaborator

rarkins commented Sep 17, 2021

We can use eg allVersioning

@RahulGautamSingh
Copy link
Collaborator

Can you assign it to me , I will start working on it.

@RahulGautamSingh
Copy link
Collaborator

RahulGautamSingh commented Sep 17, 2021

We can use eg allVersioning

allVersioning is already in use.

/workspaces/renovate/lib/versioning/index.spec.ts
line 34: const vers = allVersioning.getVersionings();

I think using versions will be better.

@RahulGautamSingh
Copy link
Collaborator

I googled versioning and it turns out that we cannot use versions inplace of versionings because versionings is not a word and even if we want to use it then it will have different meaning to versions.

@rarkins rarkins closed this as completed Sep 19, 2021
@rarkins
Copy link
Collaborator

rarkins commented Sep 19, 2021

I prefer we move on, this issue is really not important as these variable names are entirely internal. "Versioning" is a Renovate term

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:requirements Full requirements are not yet known, so implementation should not be started type:refactor Refactoring or improving of existing code
Projects
None yet
Development

No branches or pull requests

3 participants