Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/terraform): support range strategy update lockfile #11720

Merged

Conversation

secustor
Copy link
Collaborator

Changes:

Adapt the Terraform manager and Hashicorp versioning to allow the rangeStrategy update-lockfile

Context:

#11701

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

https://github.com/secustor/terraform-pessimistic-version-constraint

@secustor secustor changed the title Support range strategy update lockfile feat(manager/terraform): support range strategy update lockfile Sep 13, 2021
@viceice viceice self-requested a review September 14, 2021 05:35
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs code coverage

lib/manager/terraform/extract.spec.ts Outdated Show resolved Hide resolved
lib/manager/terraform/util.ts Show resolved Hide resolved
lib/manager/terraform/util.ts Outdated Show resolved Hide resolved
lib/manager/terraform/extract.spec.ts Outdated Show resolved Hide resolved
lib/manager/terraform/extract.ts Outdated Show resolved Hide resolved
lib/manager/terraform/lockfile/index.ts Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small cleanup

lib/manager/terraform/extract.spec.ts Show resolved Hide resolved
lib/manager/terraform/extract.spec.ts Show resolved Hide resolved
lib/manager/terraform/extract.spec.ts Show resolved Hide resolved
@viceice viceice enabled auto-merge (squash) September 14, 2021 17:14
@viceice viceice enabled auto-merge (squash) September 14, 2021 18:47
@viceice viceice enabled auto-merge (squash) September 15, 2021 07:12
@viceice viceice merged commit 12ae0d1 into renovatebot:main Sep 15, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 27.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2021
@secustor secustor deleted the support_rangeStrategy_update-lockfile branch December 4, 2022 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants