Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix vscode jest timeout #11764

Merged
merged 6 commits into from Sep 16, 2021
Merged

test: fix vscode jest timeout #11764

merged 6 commits into from Sep 16, 2021

Conversation

uncycler
Copy link
Contributor

@uncycler uncycler commented Sep 15, 2021

This only changes jest timeout for vscode


Changes:

  • Copy user attribute to token when the token is already part of it.
  • Fix vscode jest arguments for remote container.

Context:

The PR #11722 I proposed for fixing #11710 is not working. I'm not sure if it's the good way to do it, but this PR should definitely fix #11710. I've tried with bitbucket, github and gitlab.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think #11760 is a better solution

@viceice viceice changed the title fix(util): getHttpUrl is overwriting the username set by platform (fix #11710) fix(util): getHttpUrl is overwriting the username set by platform Sep 15, 2021
@uncycler
Copy link
Contributor Author

Awesome, I missed it. Thanks!

@uncycler uncycler closed this Sep 15, 2021
@viceice
Copy link
Member

viceice commented Sep 16, 2021

Can you reopen this PR and only make the vscode jest setting please?

lib/util/git/url.spec.ts Outdated Show resolved Hide resolved
lib/util/git/url.ts Outdated Show resolved Hide resolved
@viceice viceice reopened this Sep 16, 2021
@viceice viceice changed the title fix(util): getHttpUrl is overwriting the username set by platform test: fix vscode jest timeout Sep 16, 2021
@viceice viceice enabled auto-merge (squash) September 16, 2021 06:36
@viceice viceice merged commit a8ddcae into renovatebot:main Sep 16, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 27.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetching gitlab submodules now fails with 403. oauth2 is stripped from URL.
3 participants