New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix vscode jest timeout #11764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
requested changes
Sep 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think #11760 is a better solution
viceice
changed the title
fix(util): getHttpUrl is overwriting the username set by platform (fix #11710)
fix(util): getHttpUrl is overwriting the username set by platform
Sep 15, 2021
Awesome, I missed it. Thanks! |
Can you reopen this PR and only make the vscode jest setting please? |
viceice
reviewed
Sep 16, 2021
viceice
changed the title
fix(util): getHttpUrl is overwriting the username set by platform
test: fix vscode jest timeout
Sep 16, 2021
viceice
approved these changes
Sep 16, 2021
🎉 This PR is included in version 27.9.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only changes jest timeout for vscode
Changes:
Context:
The PR #11722 I proposed for fixing #11710 is not working. I'm not sure if it's the good way to do it, but this PR should definitely fix #11710. I've tried with bitbucket, github and gitlab.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: