Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log urls in closing stats #11798

Merged
merged 1 commit into from Sep 17, 2021
Merged

feat: log urls in closing stats #11798

merged 1 commit into from Sep 17, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Sep 17, 2021

Changes:

Logs all URLs in debug stats

Context:

Easier to see how repos consume API requests.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator Author

rarkins commented Sep 17, 2021

Example output:

DEBUG: http statistics (repository=renovate-tests/npm62)
       "urls": {
         "https://api.github.com/graphql (POST)": 5,
         "https://api.github.com/repos/renovate-tests/npm62/commits/renovate/renovate-26.x/check-runs (GET)": 1,
         "https://api.github.com/repos/renovate-tests/npm62/commits/renovate/renovate-26.x/status (GET)": 1,
         "https://api.github.com/repos/renovate-tests/npm62/commits/renovate/renovate-27.x/check-runs (GET)": 1,
         "https://api.github.com/repos/renovate-tests/npm62/commits/renovate/renovate-27.x/status (GET)": 1,
         "https://api.github.com/repos/renovate-tests/npm62/issues/3 (GET)": 2,
         "https://api.github.com/repos/renovate-tests/npm62/issues/3 (PATCH)": 1,
         "https://api.github.com/repos/renovate-tests/npm62/pulls (GET)": 1,
         "https://api.github.com/repos/renovate-tests/npm62/pulls (POST)": 1,
         "https://api.github.com/repos/renovate-tests/npm62/pulls/2 (PATCH)": 1,
         "https://api.github.com/repos/renovate-tests/npm62/pulls/5 (GET)": 1,
         "https://api.github.com/repos/renovatebot/renovate (GET)": 1,
         "https://api.github.com/repos/renovatebot/renovate/git/trees/main (GET)": 1,
         "https://api.github.com/repos/renovatebot/renovate/releases (GET)": 1,
         "https://api.github.com/repos/renovatebot/renovate/tags (GET)": 1,
         "https://api.github.com/repositories/76734068/releases (GET)": 9,
         "https://api.github.com/repositories/76734068/tags (GET)": 9,
         "https://registry.npmjs.org/renovate (GET)": 1
       },
       "hostStats": {
         "api.github.com": {"requestCount": 38, "requestAvgMs": 651, "queueAvgMs": 0},
         "registry.npmjs.org": {
           "requestCount": 1,
           "requestAvgMs": 1507,
           "queueAvgMs": 1
         }
       },
       "totalRequests": 39

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully all embedded token are sanitized. 🤞

@rarkins rarkins merged commit 66bc252 into main Sep 17, 2021
@rarkins rarkins deleted the feat/log-urls branch September 17, 2021 18:06
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 27.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants