Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovatebot hangs on "git commit" #11813

Closed
Turbo87 opened this issue Sep 20, 2021 · 7 comments
Closed

Renovatebot hangs on "git commit" #11813

Turbo87 opened this issue Sep 20, 2021 · 7 comments
Labels
status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality

Comments

@Turbo87
Copy link
Contributor

Turbo87 commented Sep 20, 2021

How are you running Renovate?

Self-hosted

Please select which platform you are using if self-hosting.

GitLab self-hosted

If you're self-hosting Renovate, tell us what version of Renovate you run.

27.14.0 (previously 26.21.7)

Describe the bug

After updating renovatebot to v27 it hangs forever on the git commit step, unfortunately without any kind of error message.

I expect this to be related to #11401, but I'm not sure what to do about it.

We are currently running renovatebot on the node:16 Docker image, in case that matters. Sadly, I've not been able to reproduce this outside of our setup here yet.

Relevant debug logs

Logs
DEBUG: Found 4 comments (repository=npm-packages/qonto-ui-kit, branch=deps-bf52376594)
DEBUG: 2 file(s) to commit (repository=npm-packages/qonto-ui-kit, branch=deps-bf52376594)
DEBUG: Committing files to branch deps-bf52376594 (repository=npm-packages/qonto-ui-kit, branch=deps-bf52376594)
DEBUG: Setting git author name (repository=npm-packages/qonto-ui-kit, branch=deps-bf52376594)
       "gitAuthorName": "Renovate Bot"
DEBUG: Setting git author email (repository=npm-packages/qonto-ui-kit, branch=deps-bf52376594)
       "gitAuthorEmail": "bot@renovateapp.com"
DEBUG: git commit (repository=npm-packages/qonto-ui-kit, branch=deps-bf52376594)
       "deletedFiles": [],
       "ignoredFiles": [],
       "result": {
         "author": null,
         "branch": "deps-bf52376594",
         "commit": "9d9d346d",
         "root": false,
         "summary": {"changes": 2, "insertions": 84, "deletions": 42}
       }

Have you created a minimal reproduction repository?

No reproduction repository

@Turbo87 Turbo87 added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality labels Sep 20, 2021
@Turbo87
Copy link
Contributor Author

Turbo87 commented Sep 20, 2021

now that I think about it, since the debug output already has a commit value, maybe it's the step after git commit that freezes, not the git commit itself 🤔

@rarkins
Copy link
Collaborator

rarkins commented Sep 20, 2021

Perhaps the git push stage? Are you able to get logs from GitLab?

BTW we don't support / have not tested against Node 16

@Turbo87
Copy link
Contributor Author

Turbo87 commented Sep 20, 2021

we don't support / have not tested against Node 16

interesting. we ran into different issues when still running renovatebot on Node 14, which is why we upgraded to 16. unfortunately I don't recall what exactly these issues were.

Are you able to get logs from GitLab?

only the debug logs from renovatebot and those stop after the git commit output

@viceice
Copy link
Member

viceice commented Sep 20, 2021

also please verify that you have git > v2.33

best is you use our renovate/node:14 image it has required git version installed.

@Turbo87
Copy link
Contributor Author

Turbo87 commented Sep 20, 2021

best is you use our renovate/node:14 image it has required git version installed.

I will try that. thanks :)

one other thing to note is that unfortunately the dry run does not experience the same problem, but it looks like that also never runs the git commit command, so it won't catch that issue.

@viceice
Copy link
Member

viceice commented Sep 20, 2021

@rarkins I think we can move this to discussions, as i don't see a renovate bug here. I'm using renovate v27.12.0 successfully on gitlab v14.2.3.

@Turbo87
Copy link
Contributor Author

Turbo87 commented Sep 20, 2021

we can actually close it, apparently. using renovate/node:14 with v27 does seem to resolve the issue. thanks @viceice! :)

@Turbo87 Turbo87 closed this as completed Sep 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants