Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Maven versioning tests #11826

Merged
merged 7 commits into from Sep 27, 2021

Conversation

zharinov
Copy link
Collaborator

Changes:

Use table syntax for versioning testing.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice previously approved these changes Sep 21, 2021
rarkins
rarkins previously approved these changes Sep 21, 2021
@rarkins rarkins enabled auto-merge (squash) September 21, 2021 04:54
@viceice
Copy link
Member

viceice commented Sep 21, 2021

Missing coverage

@zharinov
Copy link
Collaborator Author

Yes, but unfortunately I can't see what lines aren't covered

@viceice
Copy link
Member

viceice commented Sep 21, 2021

Yes, but unfortunately I can't see what lines aren't covered

It seems codecov isn't detecting it, so you need to manually run it locally 😏

auto-merge was automatically disabled September 27, 2021 08:11

Head branch was pushed to by a user without write access

@zharinov zharinov dismissed stale reviews from rarkins and viceice via e001573 September 27, 2021 08:11
@zharinov
Copy link
Collaborator Author

I've figured it out in last commit, it had something to do with modules import

@rarkins rarkins merged commit f25a05f into renovatebot:main Sep 27, 2021
@rarkins rarkins deleted the refactor/maven-versioning-tests branch September 27, 2021 09:00
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 27.19.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants