Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gradle): support gradlePluginPortal() #11894

Merged
merged 5 commits into from Oct 3, 2021
Merged

fix(gradle): support gradlePluginPortal() #11894

merged 5 commits into from Oct 3, 2021

Conversation

JavierSegoviaCordoba
Copy link
Contributor

Changes:

Fixes #11893

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@JavierSegoviaCordoba JavierSegoviaCordoba force-pushed the fix-gradle-plugin-portal branch 2 times, most recently from d66043e to ea233e6 Compare September 25, 2021 19:20
viceice
viceice reviewed Sep 25, 2021
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not force push, just push an new commit. We squash merge anyways. 😉

@JavierSegoviaCordoba
Copy link
Contributor Author

@viceice ah sorry, I was fixing eslint issues, IntelliJ was conflicting the formatting automatically on commit.

viceice
viceice reviewed Sep 25, 2021
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs snapshot updates

@JavierSegoviaCordoba
Copy link
Contributor Author

@viceice what do you mean with snapshot updates?

@viceice
Copy link
Member

viceice commented Sep 25, 2021

Run yarn jest -u. 😉

@JavierSegoviaCordoba
Copy link
Contributor Author

@viceice not sure if you were referring to add samples to build.gradle.example1 and get the new snapshots.

zharinov
zharinov approved these changes Sep 27, 2021
View reviewed changes
Copy link
Collaborator

@zharinov zharinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JavierSegoviaCordoba
Copy link
Contributor Author

Is there something blocking this one?

@rarkins rarkins enabled auto-merge (squash) October 3, 2021 04:56
@rarkins rarkins merged commit 71679f4 into renovatebot:main Oct 3, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 27.25.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zharinov zharinov zharinov approved these changes

@rarkins rarkins rarkins approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gradlePluginPortal() is not supported
5 participants
@JavierSegoviaCordoba @viceice @renovate-release @zharinov @rarkins