Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docker): replace www-authenticate with auth-header #11942

Merged
merged 4 commits into from Oct 1, 2021

Conversation

JamieMagee
Copy link
Contributor

Changes:

Replaces the dependency www-authenticate with auth-header

Context:

Closes #9645

I've been creating PRs against DefinitelyTyped to upstream our types, and noticed that there was an open issue to replace www-authenticate with auth-header. I made that change instead of upstreaming the types.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@JamieMagee JamieMagee changed the title refactory(docker): replace www-authenticate with auth-header refactor(docker): replace www-authenticate with auth-header Sep 29, 2021
rarkins
rarkins previously approved these changes Sep 29, 2021
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

lib/datasource/docker/common.ts Outdated Show resolved Hide resolved
@JamieMagee JamieMagee enabled auto-merge (squash) October 1, 2021 01:27
@JamieMagee JamieMagee merged commit 41bafac into main Oct 1, 2021
@JamieMagee JamieMagee deleted the refactor/www-authenticate branch October 1, 2021 19:50
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 27.25.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider replacing "www-authenticate" dependency to "auth-header"
4 participants