Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presets): Spring Boot group includes Gradle plugin #11953

Merged
merged 2 commits into from Sep 29, 2021

Conversation

Xendar
Copy link
Contributor

@Xendar Xendar commented Sep 29, 2021

Changes:

Including a matchPackagePrefixes for the Spring Boot Gradle plugin for the group:springBoot preset.

Context:

Closes #11950

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

N.B.: I think no update of documentation is required as it should be updated automatically, let me know if I'm wrong!

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

N.B.: Tested on my self-hosted Renovate, the grouping was successful

@CLAassistant
Copy link

CLAassistant commented Sep 29, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix git author and do a force push

lib/config/presets/internal/group.ts Outdated Show resolved Hide resolved
@Xendar
Copy link
Contributor Author

Xendar commented Sep 29, 2021

Fix git author and do a force push

Apologies, I misconfigured my repository. It has been fixed

@Xendar Xendar requested a review from viceice September 29, 2021 16:05
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should work as expected

@viceice viceice merged commit 79e65bd into renovatebot:main Sep 29, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 27.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Xendar Xendar deleted the issue/11950 branch September 29, 2021 20:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group preset group:springBoot does not match Spring Boot Gradle plugin
4 participants