Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): add support for authenticating at ECR with session tokens #11967

Merged

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Sep 30, 2021

Changes:

When authenticating at ECR registries interpret a token configured in host rules as AWS session token.

Context:

Closes #11956

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

It seems that InterceptorOptions.reqheaders does not work as expected.
…ens/renovate into feat/ecr-support-for-session-tokens
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to check other datasource tests too

@fgreinacher fgreinacher marked this pull request as ready for review September 30, 2021 20:08
@rarkins rarkins enabled auto-merge (squash) October 1, 2021 06:05
@rarkins rarkins merged commit b4a8406 into renovatebot:main Oct 1, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 27.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fgreinacher fgreinacher deleted the feat/ecr-support-for-session-tokens branch October 1, 2021 07:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for passing session token in AWS ECR requests
4 participants