refactor(regex): cleanup up index.ts and move matchStringStrategy to enum #12525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secustor
changed the title
viceice
reviewed
Nov 6, 2021
viceice
previously approved these changes
Nov 6, 2021
# Conflicts: # lib/manager/regex/index.ts
rarkins
force-pushed
the
refactor_regex
branch
from
353ed49
to
14c14a7
Compare
rarkins
approved these changes
Dec 10, 2021
|
🎉 This PR is included in version 30.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
refactors regex manager for better readability
use an enum for
matchStringStrategyinstead of stringContext:
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
https://github.com/secustor/renovate-regex-tests