fix(manager/sbt): support more seq constructors #12541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
previously approved these changes
Nov 7, 2021
viceice
changed the title
|
Needs a |
auto-merge was automatically disabled
November 7, 2021 20:01
Head branch was pushed to by a user without write access
rarkins
previously approved these changes
Nov 8, 2021
|
And now the unit tests are failing. So there's more work to be done before this can be merged. |
auto-merge was automatically disabled
November 8, 2021 20:47
Head branch was pushed to by a user without write access
|
At this point, everything passes for me locally. Should have checked from the start, sorry about that! |
rarkins
approved these changes
Dec 10, 2021
|
🎉 This PR is included in version 30.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Add List and Stream as alternative patterns for Seq for sbt
Context:
Renovate seems to only recognize Seqs created with Seq(...). Seqs created in other ways, like for example with List(...) or Stream(...) are not matched. This PR also matches those constructors.
That at least plugs some of the list options. There are infinitely many more, but hopefully they are less common. It's not entirely trivial to follow how the document is parsed exactly./
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: