Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gradle): Handle scala version interpolation #12989

Merged
merged 3 commits into from Dec 8, 2021
Merged

fix(gradle): Handle scala version interpolation #12989

merged 3 commits into from Dec 8, 2021

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Dec 7, 2021

Changes:

  • Handle interpolation but allow in-place version replacement

Context:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov
Copy link
Collaborator Author

zharinov commented Dec 7, 2021

Test: https://github.com/renovate-testing/test-12854-gradle-var-parser/pulls

viceice
viceice approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@rarkins rarkins enabled auto-merge (squash) December 8, 2021 04:08
@rarkins rarkins merged commit 3192235 into renovatebot:main Dec 8, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 29.33.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gradle skips some dependencies with variables
4 participants
@zharinov @renovate-release @viceice @rarkins