Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): group kubernetes dependencies #13007

Merged
merged 2 commits into from Dec 8, 2021

Conversation

secustor
Copy link
Collaborator

@secustor secustor commented Dec 8, 2021

Changes:

Group repos which are used during staging in Kubernetes.
https://github.com/kubernetes/kubernetes/blob/master/staging/README.md

Context:

Closes #12966

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor secustor changed the title feat(presets) group kubernetes dependencies feat(presets): group kubernetes dependencies Dec 8, 2021
@rarkins
Copy link
Collaborator

rarkins commented Dec 8, 2021

@secustor should this go in group:recommended?

@rarkins rarkins enabled auto-merge (squash) December 8, 2021 12:32
@secustor secustor marked this pull request as draft December 8, 2021 12:33
@secustor
Copy link
Collaborator Author

secustor commented Dec 8, 2021

Yes, it should be in the recommended group.

Converting this draft, as I have seeing right now that renovate picks up retracted versions of client-go
mmmake-gmbh/cert-manager-webhook-project-pinto#25
https://pkg.go.dev/k8s.io/client-go@v1.5.2

Should we simply disable the grouping of this module or create a fix first?

@rarkins rarkins marked this pull request as ready for review December 8, 2021 13:11
@rarkins rarkins enabled auto-merge (squash) December 8, 2021 13:12
@rarkins rarkins merged commit 65ed85a into renovatebot:main Dec 8, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 29.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@secustor secustor deleted the add_mono_repos branch December 8, 2021 14:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat Kubernetes repositories as monorepo
4 participants