Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor dry-run option #14849

Merged
merged 24 commits into from
Apr 11, 2022
Merged

feat: refactor dry-run option #14849

merged 24 commits into from
Apr 11, 2022

Conversation

MaronHatoum
Copy link
Contributor

@MaronHatoum MaronHatoum commented Mar 29, 2022 •
edited by rarkins

Changes

added new dryRun options + migration

Context

Closes #14355

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice changed the title Feat/dry run options feat: refactor dry-run option Mar 29, 2022
rarkins
rarkins requested changes Mar 29, 2022
View reviewed changes
lib/workers/repository/dependency-dashboard.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/automerge.spec.ts Outdated Show resolved Hide resolved
@rarkins
Copy link
Collaborator

rarkins commented Mar 30, 2022

@bobvandevijver does this look ok to you?

@bobvandevijver
Copy link
Contributor

Looks like my PR (#14834) has been included in here now, so lgtm 👍

With the changes in this PR:

$ node -r ts-node/register/transpile-only -- lib/renovate.ts --dry-run
 WARN: cli config dryRun property has been changed to full

Behaviour of broken 32.9.0:

$ node -r ts-node/register/transpile-only -- lib/renovate.ts --dry-run
error: option '--dry-run <string>' argument missing

@viceice
Copy link
Member

viceice commented Mar 30, 2022

will test and review tomorrow morning

viceice
viceice reviewed Mar 30, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some pending comments. 🙈🤫🤗

lib/config/migration.ts Outdated Show resolved Hide resolved
lib/workers/global/config/parse/cli.ts Show resolved Hide resolved
lib/config/types.ts Outdated Show resolved Hide resolved
@MaronHatoum
Copy link
Contributor Author

Hi @viceice
any more changes required?

@MaronHatoum MaronHatoum requested a review from viceice April 5, 2022 09:04
viceice
viceice reviewed Apr 8, 2022
View reviewed changes
lib/workers/global/config/parse/cli.ts Outdated Show resolved Hide resolved
lib/workers/global/config/parse/cli.ts Outdated Show resolved Hide resolved
rarkins and others added 2 commits April 8, 2022 08:19
rarkins
rarkins previously approved these changes Apr 8, 2022
View reviewed changes
viceice
viceice reviewed Apr 8, 2022
View reviewed changes
lib/workers/global/config/parse/cli.spec.ts Show resolved Hide resolved
lib/workers/global/config/parse/cli.ts Outdated Show resolved Hide resolved
lib/workers/global/config/parse/env.ts Outdated Show resolved Hide resolved
@MaronHatoum MaronHatoum requested a review from viceice April 9, 2022 06:57
viceice
viceice reviewed Apr 9, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 don't we have a coercion for 'null' to null for cli and / or env config?

rarkins
rarkins previously approved these changes Apr 10, 2022
View reviewed changes
viceice
viceice requested changes Apr 11, 2022
View reviewed changes
lib/workers/global/config/parse/cli.ts Outdated Show resolved Hide resolved
@viceice viceice enabled auto-merge (squash) April 11, 2022 20:04
@viceice viceice merged commit 3e312fd into renovatebot:main Apr 11, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@astellingwerf astellingwerf mentioned this pull request Apr 18, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend dryRun options to extract, lookup, update
5 participants
@MaronHatoum @rarkins @bobvandevijver @viceice @renovate-release