Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve renovate flow graph #15043

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Conversation

PhilipAbed
Copy link
Collaborator

Changes

small fix for the extraction and lookup section

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new layout, it's easier to understand the extractDependencies part now.

The maintainers should check if the graph is technically correct. 😉


Also, the PR title should be changed to something like this: docs: improve renovate flow graph or something similar, right now it's not following the SemVer commit message style.

@PhilipAbed PhilipAbed changed the title Update renovate-flow.md docs: Update renovate-flow.md with new extract Apr 11, 2022
@PhilipAbed PhilipAbed changed the title docs: Update renovate-flow.md with new extract docs: improve renovate flow graph Apr 11, 2022
@PhilipAbed
Copy link
Collaborator Author

I follow the code step by step, but everytime i discover new stuff i will just add to the flow.
i noticed also we need new deeper Graphs for the Extract / Lookup / update / branch creation /PR creation /models

i made sure that if i needed something while coding, i could just look at it and know what's up, it shows the whole picture where the "generalization/abstraction" happens and in which TS files even.
and it is already helping!.

so what do you think about Deeper depth graphs (i still dont have enough knowledge to do that 100% still) but we could work it out step by step.
I'm talking about More graphs in different Areas..
we can open a discussion on this i guess xD

@rarkins rarkins merged commit 927bb5f into renovatebot:main Apr 11, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants