Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(versioning/distro): added functionality for debian #15051

Merged

Conversation

Gabriel-Ladzaretti
Copy link
Collaborator

@Gabriel-Ladzaretti Gabriel-Ladzaretti commented Apr 11, 2022

Changes

For future use in the debian versioning API.

blocks #14881

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Gabriel-Ladzaretti Gabriel-Ladzaretti marked this pull request as ready for review April 11, 2022 08:53
lib/modules/versioning/distro.spec.ts Outdated Show resolved Hide resolved
lib/modules/versioning/distro.spec.ts Outdated Show resolved Hide resolved
lib/modules/versioning/distro.ts Outdated Show resolved Hide resolved
lib/modules/versioning/distro.ts Show resolved Hide resolved
Added tsdoc comments

Modified unit tests with newer values

Typo fix per CR
Added unit tests for getNLatest: - out of bounds & float args
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small suggestions.

you can apply them on github review as batch 😉

lib/modules/versioning/distro.ts Outdated Show resolved Hide resolved
lib/modules/versioning/distro.ts Outdated Show resolved Hide resolved
lib/modules/versioning/distro.spec.ts Outdated Show resolved Hide resolved
Apply suggestions from code review

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@viceice viceice enabled auto-merge (squash) April 14, 2022 13:18
@viceice viceice merged commit 5304734 into renovatebot:main Apr 14, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
@Gabriel-Ladzaretti Gabriel-Ladzaretti deleted the refactor-versioning-distro branch June 26, 2022 07:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants