Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cleanup snapshot tests #15082

Merged
merged 1 commit into from
Apr 12, 2022
Merged

test: cleanup snapshot tests #15082

merged 1 commit into from
Apr 12, 2022

Conversation

viceice
Copy link
Member

@viceice viceice commented Apr 12, 2022

Changes

  • remove request trace snapshot tests
  • add other expectations as required
  • remove null snapshots

Context

Saves some test time on windows because of slow io.
Should also reduce memory footprint for big snapshot strings.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins April 12, 2022 13:52
@rarkins rarkins enabled auto-merge (squash) April 12, 2022 13:57
@viceice viceice added the ci:fulltest Run full test suite on all platforms label Apr 12, 2022
@rarkins rarkins disabled auto-merge April 12, 2022 14:09
@rarkins rarkins merged commit 443bef5 into main Apr 12, 2022
@rarkins rarkins deleted the test/snapshots branch April 12, 2022 14:09
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.19.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci:fulltest Run full test suite on all platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants