-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helmfile): remove go templating strings on a best effort basis for yaml parsing #15106
fix(helmfile): remove go templating strings on a best effort basis for yaml parsing #15106
Conversation
Signed-off-by: Jack Andersen <jandersen@plaid.com>
…narios Signed-off-by: Jack Andersen <jandersen@plaid.com>
Sounds good! I just wasn't sure if you wanted me to add additional work or if I had done things improperly in the first place. Thank you for linking the guidelines though, I will keep that in mind going forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly done
🎉 This PR is included in version 32.27.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
This PR introduces simple regex parsing (as suggested in the linked Issue) which will remove the Go templating from the helmfile in an attempt to make it closer to pure YAML.
Note that this doesn't actually solve the problem (which is that the go templates need to be parsed), but it does a hacky enough half measure that this should work for most use cases.
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: