Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helmfile): remove go templating strings on a best effort basis for yaml parsing #15106

Merged

Conversation

jandersen-plaid
Copy link
Contributor

@jandersen-plaid jandersen-plaid commented Apr 13, 2022

Changes

This PR introduces simple regex parsing (as suggested in the linked Issue) which will remove the Go templating from the helmfile in an attempt to make it closer to pure YAML.

Note that this doesn't actually solve the problem (which is that the go templates need to be parsed), but it does a hacky enough half measure that this should work for most use cases.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Signed-off-by: Jack Andersen <jandersen@plaid.com>
@jandersen-plaid jandersen-plaid changed the title Remove go templating strings on a best effort basis for yaml parsing fix(helmfile): remove go templating strings on a best effort basis for yaml parsing Apr 13, 2022
lib/modules/manager/helmfile/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/helmfile/extract.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/helmfile/extract.ts Outdated Show resolved Hide resolved
@jandersen-plaid
Copy link
Contributor Author

please read https://github.com/renovatebot/renovate/blob/main/.github/contributing.md#resolve-review-comments-instead-of-commenting 🤗

Sounds good! I just wasn't sure if you wanted me to add additional work or if I had done things improperly in the first place. Thank you for linking the guidelines though, I will keep that in mind going forward.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly done

lib/modules/manager/helmfile/extract.ts Outdated Show resolved Hide resolved
@viceice viceice merged commit 2af3717 into renovatebot:main Apr 22, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.27.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helmfile extract fails with local-chart and templated name
4 participants