Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: strict null checks for util #15150

Merged
merged 8 commits into from
Apr 17, 2022
Merged

refactor: strict null checks for util #15150

merged 8 commits into from
Apr 17, 2022

Conversation

viceice
Copy link
Member

@viceice viceice commented Apr 16, 2022

Changes

  • make util null safe

Context

  • #7154

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice enabled auto-merge (squash) April 16, 2022 20:12
viceice
viceice commented Apr 17, 2022
View reviewed changes
tsconfig.strict.json Outdated Show resolved Hide resolved
JamieMagee
JamieMagee previously approved these changes Apr 17, 2022
View reviewed changes
Copy link
Contributor

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but disabled automerge because it looks like you're still pushing commits.

viceice
viceice commented Apr 17, 2022
View reviewed changes
lib/util/package-rules.ts Outdated Show resolved Hide resolved
viceice
viceice commented Apr 17, 2022
View reviewed changes
lib/util/package-rules.ts Outdated Show resolved Hide resolved
@viceice viceice requested a review from JamieMagee April 17, 2022 06:23
@viceice
Copy link
Member Author

viceice commented Apr 17, 2022

Approved, but disabled automerge because it looks like you're still pushing commits.

Yes, sorry. failed tests and coverage. 🙈

@viceice
Copy link
Member Author

viceice commented Apr 17, 2022

runned full suite locally, so tests and coverage should be really fixed now 🙈

@viceice viceice mentioned this pull request Apr 17, 2022
Merged
6 tasks
@viceice viceice enabled auto-merge (squash) April 17, 2022 07:44
@viceice viceice merged commit 955b442 into main Apr 17, 2022
@viceice viceice deleted the refactor/strict-null branch April 17, 2022 09:07
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.25.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@zharinov zharinov Awaiting requested review from zharinov

@JamieMagee JamieMagee Awaiting requested review from JamieMagee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@viceice @renovate-release @JamieMagee @rarkins