Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(manager/poetry): strict type checks #15152

Merged
merged 4 commits into from
Apr 18, 2022

Conversation

hasanwhitesource
Copy link
Contributor

Changes

  • Removed any types
  • Refactored foreach
  • String check instead of using typeof

Context

Ref: #7154

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

please check my PR to not make changes to those files. 😉

lib/modules/manager/poetry/extract.ts Outdated Show resolved Hide resolved
@viceice
Copy link
Member

viceice commented Apr 18, 2022

https://github.com/renovatebot/renovate/blob/main/.github/contributing.md#re-requesting-a-review 😉

@viceice viceice enabled auto-merge (squash) April 18, 2022 08:23
@viceice viceice merged commit 1f84225 into renovatebot:main Apr 18, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.26.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants