Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(versioning/ubuntu): Postpone offering new releases #15204

Merged

Conversation

Gabriel-Ladzaretti
Copy link
Collaborator

@Gabriel-Ladzaretti Gabriel-Ladzaretti commented Apr 20, 2022

Changes

Postpone offering new releases by one week.

22.04 jammy is around the corner, should we be on the safe side and postpone updates?
currently we will start offering updates on the 21th, local time. delaying it might be a good idea.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice previously approved these changes Apr 20, 2022
@Gabriel-Ladzaretti Gabriel-Ladzaretti changed the title feat(versioning/ubuntu): Postpone offering new releases refactor(versioning/ubuntu): Postpone offering new releases Apr 20, 2022
@rarkins rarkins enabled auto-merge (squash) April 20, 2022 20:37
@Gabriel-Ladzaretti
Copy link
Collaborator Author

This pull request will squash and merge automatically when all requirements are met

just curious, what are these so called requirements? obviously required changes and approval.
any thing else?
thought pending review requests was preventing this from being merged, guess not...

@viceice
Copy link
Member

viceice commented Apr 21, 2022

branch is out of date, which is blocking automerge 😉

@viceice viceice disabled auto-merge April 21, 2022 02:02
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably use UTC instead of local time compare, so we're independent of time zone

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rarkins I'm not longer sure if we should defer the update here. 🤔

@viceice viceice requested a review from rarkins April 21, 2022 06:07
@rarkins
Copy link
Collaborator

rarkins commented Apr 21, 2022

It's still future here: https://wiki.ubuntu.com/Releases

@rarkins
Copy link
Collaborator

rarkins commented Apr 21, 2022

I think one day is conservative enough. I'll merge this so that we can get tests to pass

@rarkins rarkins enabled auto-merge (squash) April 21, 2022 08:41
@rarkins rarkins merged commit 8b003e1 into renovatebot:main Apr 21, 2022
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
@Gabriel-Ladzaretti Gabriel-Ladzaretti deleted the fix-versioning-distros-postpone branch June 26, 2022 07:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants